Project

General

Profile

Actions

Bug #8453

closed

Change in group may be overwritten by dynamic group update

Added by Nicolas CHARLES almost 5 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
1
Category:
Web - Nodes & inventories
Target version:
Severity:
User visibility:
Effort required:
Priority:
Tags:

Description

If we are unlucky enough to edit a group right when the dynamic group update is running, and saving this specific group, we may have all of our change that is overwritten
In DynGroupUpdater, we:
  1. load the group
  2. check it's dynamic
  3. get its query
  4. compute new members
  5. save it if they change

Last step should ensure that:
- we don't overwrite query
- if query changed between step 3 and save, rerun the update

Result can be pretty surprising, as group config looks ok, but isn't

Actions #1

Updated by François ARMAND almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #2

Updated by François ARMAND almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/1114
Actions #3

Updated by François ARMAND almost 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #4

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 2.11.23 to 2.11.22
Actions #5

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.22, 3.0.17, 3.1.11 and 3.2.4 which were released today.

Actions

Also available in: Atom PDF