Project

General

Profile

Actions
Copy link

Bug #8573

closed

Smelly code in logger_rudder

Added by Benoît PECCATTE almost 8 years ago. Updated almost 2 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
Jonathan CLARKE
Category:
Generic methods
Target version:
ncf-0.x
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

In logger_rudder.cf, we have the following code twice

(logger_rudder_final_resfile_repaired|logger_rudder_temp_resfile_kept.!logger_rudder_temp_resfile_repaired.final_resfile_exists)::

The parens are either unneeded or at the wrong place.
Either way, there should be parens somewhere since we mix AND and OR.

Actions
Copy link

Also available in: Atom PDF