Project

General

Profile

Actions

Bug #8638

closed

file_ensure_lines_present_in_ini_section.cf test fails with CFEngine 3.9

Added by Alexis Mousset over 6 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Subtasks 1 (0 open1 closed)

Bug #9070: Conditionnal loading does not work as expectedReleasedBenoît PECCATTEActions

Related issues 1 (1 open0 closed)

Related to Rudder - Bug #18009: File in INI section method does not work as intendedPending technical reviewAlexis MoussetActions
Actions #1

Updated by Alexis Mousset over 6 years ago

The problem is the second test, the difference in the verbose logs:

verbose: Additional promise info: version '1.0' source path '/root/ncf/tests/acceptance/../../tree/20_cfe_basics/ncf_lib.cf' at line 336 comment 'Insert line in section section_test2'
 verbose: The promised end pattern '\[.*\]\s*' was not found when selecting region to insert in '/root/ncf/tests/acceptance/workdir/__30_generic_methods_file_ensure_lines_present_in_ini_section_cf/tmp/test2.ini'

(only on 3.9)

Actions #2

Updated by Alexis Mousset over 6 years ago

Maybe linked to:

EOF is  matched as an end of the region in edit_line
      promises only if 'select_end_match_eof' parameter is true.
      (Jira CFE-2263)

from 3.9 changelog.

Actions #3

Updated by Alexis Mousset over 6 years ago

That's it! We cannot use select_end_match_eof though as it is not available in 3.7, we have to fix the test.

Actions #5

Updated by Alexis Mousset about 6 years ago

  • Category set to Generic methods
Actions #6

Updated by Alexis Mousset about 6 years ago

  • Status changed from New to In progress
Actions #7

Updated by Alexis Mousset about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/438
Actions #8

Updated by Alexis Mousset about 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:3652e3fe26a994de04a3c897379ecf158c2a1eaa.

Actions #9

Updated by Alexis Mousset about 6 years ago

  • Related to Bug #9070: Conditionnal loading does not work as expected added
Actions #10

Updated by Vincent MEMBRÉ about 6 years ago

  • Related to deleted (Bug #9070: Conditionnal loading does not work as expected)
Actions #11

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in ncf version that comes with Rudder 3.1.15/14 and 3.2.8/7 which were released today.

Actions #12

Updated by Félix DALLIDET about 2 years ago

  • Related to Bug #18009: File in INI section method does not work as intended added
Actions #13

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #14

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF