Bug #8687: Inconsistent directive API parameters at creation - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open issues 8.0
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #8687

closed

Inconsistent directive API parameters at creation

Added by Alexis Mousset almost 8 years ago. Updated over 7 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

API

Target version:

2.11.23

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

In the directive API:

the priority attribute in exported, can be modified, but cannot be provided at creation
the isSystem attribute in exported, can be modified, but cannot be provided at creation
The isEnabled attribute is called enabled at creation

Subtasks 4 (0 open — 4 closed)

Bug #8715: Migrate 'api_compatibility_mode' so it's enable on migration	Released	Alexis Mousset	2016-07-20	Actions
Bug #8716: Remove 'isxxx' and add priority in Directive from api doc	Released	François ARMAND	2016-07-20	Actions
Bug #8768: Style of title Api backward compatibility in Settings is invalid	Released	Vincent MEMBRÉ	2016-07-28	Actions
Bug #8780: Test broken since we added a new entry in bootstrap.ldif ...	Released	Benoît PECCATTE	2016-07-28	Actions

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Alexis Mousset almost 8 years ago

Subject changed from Inconsistent API parameters to Inconsistent directive API parameters at creation

Actions

Copy link

Updated by François ARMAND almost 8 years ago

We need to ensure that POST (GET url_api) works.
For that case, we need to:

- just add the missing priority parameter,
- remove from documentation the "isXXX" to only keep "XXX" variant,
- keep aliases in code to node break existing script, marking "isXXX" variant deprecated,
- remove in next major API the old "isXXX" values.

Actions

Copy link

Updated by Vincent MEMBRÉ almost 8 years ago

Priority works, it just not documented.

We do not accept "isXXX" as parameter, but always "XXX". But we always answer "isXXX"

Actions

Copy link

Updated by Vincent MEMBRÉ almost 8 years ago

I don't think "system" should be set/modified

Actions

Copy link

Updated by Vincent MEMBRÉ almost 8 years ago

Assignee set to Vincent MEMBRÉ
Target version set to 2.11.23

We will:

Document priority in directive creation (another issue)
Always send 'xxx' instead of 'isxxx"
Define a new property 'api compatibility' that is 'disabled' on new install, 'enabled' on migration which allows:
- If "enabled", api will also send "isxxx" in response, which will allow compatibility with old script treating the "isxxx -> xxx" case
Deprecate all current API in master, so we can create a new one only snedinf 'xxx'
Remove all deprecated API and the property in master+1