Project

General

Profile

Actions
Copy link

Bug #8862

closed

Broken agent parsing when some report data start or ends with a separator char

Added by Alexis Mousset over 7 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
4
Assignee:
-
Category:
Agent
Target version:
5.0.15
Pull Request:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Small
Priority:
32
Name check:
Fix check:
Regression:

Description

For example

SSH key@@@ my key

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #10601: If component value starts with # , report is not outputed by rudder agent outputReleasedAlexis MoussetActions
Actions
Copy link
 #1

Updated by Alexis Mousset over 7 years ago

We need to use the same algorithm as the webapp for parsing, and check the different separators separately instead of checking for #, ##, @ or #@ to reduce the amount of failures.

Actions
Copy link
 #2

Updated by Florian Heigl over 7 years ago

in my case it turned out it's the line that sets the loghost @ip-addr from an NCF edit file.

Actions
Copy link
 #3

Updated by Florian Heigl over 7 years ago

consider if i used tcp it would even be @@ as the log destination, so this is really a nasty case :-)

Actions
Copy link
 #4

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.13 to 3.1.14
Actions
Copy link
 #5

Updated by François ARMAND over 7 years ago

  • Assignee set to Benoît PECCATTE
  • Priority changed from N/A to 4

It may be because regex are greedy by defaults, and should not be.

Actions
Copy link
 #6

Updated by Benoît PECCATTE over 7 years ago

  • Assignee changed from Benoît PECCATTE to Alexis Mousset
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #12

Updated by Benoît PECCATTE about 7 years ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations
Actions
Copy link
 #13

Updated by Benoît PECCATTE about 7 years ago

  • Priority set to 5
Actions
Copy link
 #14

Updated by Alexis Mousset about 7 years ago

  • Related to Bug #10601: If component value starts with # , report is not outputed by rudder agent output added
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions
Copy link
 #16

Updated by Jonathan CLARKE almost 7 years ago

  • Assignee deleted (Alexis Mousset)
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions
Copy link
 #19

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 5 to 19
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.22 to 3.1.23
  • Priority changed from 19 to 18
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.24 to 3.1.25
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 387 to 4.1.10
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions
Copy link
 #28

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
Actions
Copy link
 #29

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions
Copy link
 #31

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions
Copy link
 #32

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions
Copy link
 #33

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions
Copy link
 #34

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions
Copy link
 #35

Updated by François ARMAND about 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions
Copy link
 #36

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions
Copy link
 #37

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.22 to 4.1.23
Actions
Copy link
 #38

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.23 to 4.1.24
Actions
Copy link
 #39

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.24 to 588
Actions
Copy link
 #40

Updated by Alexis Mousset almost 5 years ago

  • Target version changed from 588 to 5.0.13
Actions
Copy link
 #41

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions
Copy link
 #42

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions
Copy link
 #43

Updated by Benoît PECCATTE over 4 years ago

  • Effort required set to Small
  • Priority changed from 18 to 32

I think the parsing has changed, but we must check this

Actions
Copy link
 #44

Updated by Alexis Mousset over 4 years ago

  • Status changed from New to Rejected

We can't do better with rsyslog/awk regexes. HTTP reporting uses a more complete parser, but our report format has no escaping mechanism so it won"t be perfect anyway.

Closing as it is not actually a bug.

Actions
Copy link

Also available in: Atom PDF