Project

General

Profile

Actions
Copy link

Bug #8862

closed

Broken agent parsing when some report data start or ends with a separator char

Bug #8862: Broken agent parsing when some report data start or ends with a separator char

Added by Alexis Mousset over 9 years ago. Updated about 6 years ago.

Status:
Rejected
Priority:
4
Assignee:
-
Category:
Agent
Target version:
5.0.15
Pull Request:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Small
Priority:
32
Name check:
Fix check:
Regression:

Description

For example

SSH key@@@ my key

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #10601: If component value starts with # , report is not outputed by rudder agent outputReleasedAlexis MoussetActions

Updated by Alexis Mousset over 9 years ago Actions
Copy link
 #1

We need to use the same algorithm as the webapp for parsing, and check the different separators separately instead of checking for #, ##, @ or #@ to reduce the amount of failures.

Updated by Florian Heigl over 9 years ago Actions
Copy link
 #2

in my case it turned out it's the line that sets the loghost @ip-addr from an NCF edit file.

Updated by Florian Heigl over 9 years ago Actions
Copy link
 #3

consider if i used tcp it would even be @@ as the log destination, so this is really a nasty case :-)

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #4

  • Target version changed from 3.1.13 to 3.1.14

Updated by François ARMAND over 9 years ago Actions
Copy link
 #5

  • Assignee set to Benoît PECCATTE
  • Priority changed from N/A to 4

It may be because regex are greedy by defaults, and should not be.

Updated by Benoît PECCATTE over 9 years ago Actions
Copy link
 #6

  • Assignee changed from Benoît PECCATTE to Alexis Mousset

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #7

  • Target version changed from 3.1.14 to 3.1.15

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #8

  • Target version changed from 3.1.15 to 3.1.16

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #9

  • Target version changed from 3.1.16 to 3.1.17

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #10

  • Target version changed from 3.1.17 to 3.1.18

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #11

  • Target version changed from 3.1.18 to 3.1.19

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #12

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #13

  • Priority set to 5

Updated by Alexis Mousset over 8 years ago Actions
Copy link
 #14

  • Related to Bug #10601: If component value starts with # , report is not outputed by rudder agent output added

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #15

  • Target version changed from 3.1.19 to 3.1.20

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #16

  • Assignee deleted (Alexis Mousset)

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #17

  • Target version changed from 3.1.20 to 3.1.21

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #18

  • Target version changed from 3.1.21 to 3.1.22

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #19

  • Priority changed from 5 to 19

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #20

  • Target version changed from 3.1.22 to 3.1.23
  • Priority changed from 19 to 18

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #21

  • Target version changed from 3.1.23 to 3.1.24

Updated by Vincent MEMBRÉ about 8 years ago Actions
Copy link
 #22

  • Target version changed from 3.1.24 to 3.1.25

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #23

  • Target version changed from 3.1.25 to 387

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #24

  • Target version changed from 387 to 4.1.10

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #25

  • Target version changed from 4.1.10 to 4.1.11

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #26

  • Target version changed from 4.1.11 to 4.1.12

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #27

  • Target version changed from 4.1.12 to 4.1.13

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #28

  • Target version changed from 4.1.13 to 4.1.14

Updated by Benoît PECCATTE over 7 years ago Actions
Copy link
 #29

  • Target version changed from 4.1.14 to 4.1.15

Updated by Vincent MEMBRÉ about 7 years ago Actions
Copy link
 #30

  • Target version changed from 4.1.15 to 4.1.16

Updated by Vincent MEMBRÉ about 7 years ago Actions
Copy link
 #31

  • Target version changed from 4.1.16 to 4.1.17

Updated by Vincent MEMBRÉ about 7 years ago Actions
Copy link
 #32

  • Target version changed from 4.1.17 to 4.1.18

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #33

  • Target version changed from 4.1.18 to 4.1.19

Updated by Alexis Mousset almost 7 years ago Actions
Copy link
 #34

  • Target version changed from 4.1.19 to 4.1.20

Updated by François ARMAND almost 7 years ago Actions
Copy link
 #35

  • Target version changed from 4.1.20 to 4.1.21

Updated by Vincent MEMBRÉ over 6 years ago Actions
Copy link
 #36

  • Target version changed from 4.1.21 to 4.1.22

Updated by Vincent MEMBRÉ over 6 years ago Actions
Copy link
 #37

  • Target version changed from 4.1.22 to 4.1.23

Updated by Vincent MEMBRÉ over 6 years ago Actions
Copy link
 #38

  • Target version changed from 4.1.23 to 4.1.24

Updated by Vincent MEMBRÉ over 6 years ago Actions
Copy link
 #39

  • Target version changed from 4.1.24 to 588

Updated by Alexis Mousset over 6 years ago Actions
Copy link
 #40

  • Target version changed from 588 to 5.0.13

Updated by Vincent MEMBRÉ over 6 years ago Actions
Copy link
 #41

  • Target version changed from 5.0.13 to 5.0.14

Updated by Vincent MEMBRÉ about 6 years ago Actions
Copy link
 #42

  • Target version changed from 5.0.14 to 5.0.15

Updated by Benoît PECCATTE about 6 years ago Actions
Copy link
 #43

  • Effort required set to Small
  • Priority changed from 18 to 32

I think the parsing has changed, but we must check this

Updated by Alexis Mousset about 6 years ago Actions
Copy link
 #44

  • Status changed from New to Rejected

We can't do better with rsyslog/awk regexes. HTTP reporting uses a more complete parser, but our report format has no escaping mechanism so it won"t be perfect anyway.

Closing as it is not actually a bug.

Actions
Copy link

Also available in: PDF Atom