Project

General

Custom queries

Profile

Actions

Bug #8862

closed

Broken agent parsing when some report data start or ends with a separator char

Added by Alexis Mousset over 8 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
4
Assignee:
-
Category:
Agent
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Small
Priority:
32
Name check:
Fix check:
Regression:

Description

For example

SSH key@@@ my key

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #10601: If component value starts with # , report is not outputed by rudder agent outputReleasedAlexis MoussetActions
Actions #1

Updated by Alexis Mousset over 8 years ago

We need to use the same algorithm as the webapp for parsing, and check the different separators separately instead of checking for #, ##, @ or #@ to reduce the amount of failures.

Actions #2

Updated by Florian Heigl over 8 years ago

in my case it turned out it's the line that sets the loghost @ip-addr from an NCF edit file.

Actions #3

Updated by Florian Heigl over 8 years ago

consider if i used tcp it would even be @@ as the log destination, so this is really a nasty case :-)

Actions #5

Updated by François ARMAND over 8 years ago

  • Assignee set to Benoît PECCATTE
  • Priority changed from N/A to 4

It may be because regex are greedy by defaults, and should not be.

Actions #43

Updated by Benoît PECCATTE over 5 years ago

  • Effort required set to Small
  • Priority changed from 18 to 32

I think the parsing has changed, but we must check this

Actions #44

Updated by Alexis Mousset over 5 years ago

  • Status changed from New to Rejected

We can't do better with rsyslog/awk regexes. HTTP reporting uses a more complete parser, but our report format has no escaping mechanism so it won"t be perfect anyway.

Closing as it is not actually a bug.

Actions

Also available in: Atom PDF