Project

General

Profile

Actions

User story #9120

open

Add Model version into group criteria ?

Added by Jérémy HOCDÉ about 8 years ago. Updated almost 7 years ago.

Status:
New
Priority:
N/A
Assignee:
-
Category:
Web - Nodes & inventories
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

Is it possible to add the System Version into group criteria ?

FusionInventory does't get this information, but dmidecode can get it

  1. dmidecode -t 1
  2. dmidecode 2.11
    SMBIOS 2.6 present.

Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 5048WAL
Version: ThinkCentre M81
Serial Number: S4EPEL4
UUID: 9B8B3830-58AD-11E1-8735-047EFB473C00
Wake-up Type: Power Switch
SKU Number: To be filled by O.E.M.
Family: To be filled by O.E.M.

It would be nice to get this criteria into dynamic group

thks a lot

Actions #1

Updated by Matthieu CERDA about 8 years ago

  • Description updated (diff)
  • Assignee set to Matthieu CERDA

Hello, thanks for the report !

I'll take a look at this :)

Actions #2

Updated by Benoît PECCATTE about 8 years ago

  • Tracker changed from Question to User story
  • Category set to Web - Nodes & inventories
Actions #3

Updated by Matthieu CERDA about 8 years ago

  • Assignee deleted (Matthieu CERDA)
  • Target version set to 4.0.0~rc2

It's actually quite easy to add:

<BIOS>
      (...)
      <SVERSION>ThinkPad X230</SVERSION>
</BIOS>

As simple as:

diff --git a/lib/FusionInventory/Agent/Inventory.pm b/lib/FusionInventory/Agent/Inventory.pm
index 73b39a7..cf0427c 100644
--- a/lib/FusionInventory/Agent/Inventory.pm
+++ b/lib/FusionInventory/Agent/Inventory.pm
@@ -12,7 +12,7 @@ use XML::TreePP;
 use FusionInventory::Agent::Tools;

 my %fields = (
-    BIOS             => [ qw/SMODEL SMANUFACTURER SSN BDATE BVERSION
+    BIOS             => [ qw/SMODEL SMANUFACTURER SVERSION SSN BDATE BVERSION
                              BMANUFACTURER MMANUFACTURER MSN MMODEL ASSETTAG
                              ENCLOSURESERIAL BIOSSERIAL
                              TYPE SKUNUMBER/ ],
diff --git a/lib/FusionInventory/Agent/Task/Inventory/Generic/Dmidecode/Bios.pm b/lib/FusionInventory/Agent/Task/Inventory/Generic/Dmidecode/Bios.pm
index 400d3bd..bc5dfc4 100644
--- a/lib/FusionInventory/Agent/Task/Inventory/Generic/Dmidecode/Bios.pm
+++ b/lib/FusionInventory/Agent/Task/Inventory/Generic/Dmidecode/Bios.pm
@@ -40,6 +40,8 @@ sub _getBiosHardware {
     $bios->{SMODEL} =
         $system_info->{'Product'}      ||
         $system_info->{'Product Name'};
+    $bios->{SVERSION} =
+        $system_info->{'Version'};
     $bios->{MMODEL} = $base_info->{'Product Name'};
     $bios->{SKUNUMBER} = $system_info->{'SKU Number'};

Of course, we would need an appropriate logic in the webapp to parse and expose this.

Actions #4

Updated by François ARMAND about 8 years ago

  • Target version changed from 4.0.0~rc2 to 4.1.0~beta1
Actions #5

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta1 to 4.1.0~beta2
Actions #6

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta2 to 4.1.0~beta3
Actions #7

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 4.1.0~beta3 to 4.1.0~rc1
Actions #8

Updated by François ARMAND almost 8 years ago

  • Target version changed from 4.1.0~rc1 to 4.2.0~beta1
Actions #9

Updated by Alexis Mousset over 7 years ago

  • Target version changed from 4.2.0~beta1 to 4.2.0~beta2
Actions #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~beta2 to 4.2.0~beta3
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~beta3 to 4.2.0~rc1
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~rc1 to 4.2.0~rc2
Actions #13

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.2.0~rc2 to 4.2.0
Actions #14

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.0 to 4.2.1
Actions #15

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.1 to 4.2.2
Actions #16

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions #17

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions #18

Updated by Benoît PECCATTE almost 7 years ago

  • Target version changed from 4.2.4 to Ideas (not version specific)
Actions

Also available in: Atom PDF