Project

General

Profile

Actions
Copy link

User story #9789

closed

rudder-jetty must support git post-commit hooks

Added by Dmitry Svyatogorov over 7 years ago. Updated about 6 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
François ARMAND
Category:
Web - Config management
Target version:
4.1.10
Pull Request:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

The last rudder-jetty 3.2.9-trusty0 (ubuntu 14.04) still does not support post-commit git hooks.
It uses /var/rudder/tmp/jetty/jetty-127.0.0.1-8080-rudder.war-_rudder-any-/webapp/WEB-INF/lib/org.eclipse.jgit-4.4.1.201607150455-r.jar
but post-commit was implemented only in 80865 https://git.eclipse.org/r/#/c/80865/ from Sep 14.
Yes, it is due to self-made git implementation in java.

Why there's need in? Because at this time rudder does not provides any fashion of post-moderation feature. Due to git-inside, there's not so complex way to jerk "git diff" from the hook and mail changes.
  • pre-commit hook works.
Actions
Copy link
 #1

Updated by Alexis Mousset over 7 years ago

  • Category set to Web - Config management
  • Assignee set to François ARMAND

François, what is your opinion about that? Could we easily update jgit in 4.1 to enable post-commit hooks?

Actions
Copy link
 #2

Updated by Alexis Mousset about 7 years ago

  • Tracker changed from Bug to User story
Actions
Copy link
 #3

Updated by Benoît PECCATTE about 6 years ago

  • Target version set to Ideas (not version specific)
Actions
Copy link
 #4

Updated by François ARMAND about 6 years ago

  • Status changed from New to Rejected
  • Target version changed from Ideas (not version specific) to 4.1.10

This is OK in Rudder 4.1 because post-commit hooks were added in jgit 4.5, and Rudder 4.1.0 use Jgit version 4.6.

Actions
Copy link

Also available in: Atom PDF