Bug #2465
closed
PT/technique "checkGenericFileContent" has a mandatory field to enforce file content
Description
This PT can now do several things: enforce a file content, delete lines, replace lines... But if you choose to just replace lines, you still have to specify some content to put into the file, which makes no sense.
1. This field should be made optional.
2. Also, the PT's layout should be clarified, to make it more obvious that you must choose a file name, then some actions, then configure these actions. I propose the attached patch for the policy.xml file but it needs checking with regard to reporting and components.
3. The variable "Enforce the content of the file:" should be a boolean, the same as the following 2, not a SELECT1 with 2 values.
Files
Updated by Matthieu CERDA over 12 years ago
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
Applied in changeset commit:c74bca73863c250c459210b4b300aadb66774190.
Updated by Matthieu CERDA over 12 years ago
I applied your patch, which is valid, but without the 'component="true"' part that would break reporting.
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Pending technical review to 2
- % Done changed from 100 to 50
I'm really not sure about this. There is now a component named "File content" which never has any reports:
<SECTION name="File content" component="true" componentKey="GENERIC_FILE_CONTENT_PATH">
I have no doubts as to whether this will break reporting. Did you test this? Please review.
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 2.3.8 to 2.3.7
Updated by Matthieu CERDA over 12 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 50 to 100
Applied in changeset commit:a8307ad80b1e2cb1eea200c2bf477a627e8447a7.
Updated by Matthieu CERDA over 12 years ago
You were right, this " <SECTION name="File content" component="true" componentKey="GENERIC_FILE_CONTENT_PATH">" part should not be here... I made it component="false", now we get all the expected reports.
Updated by Nicolas PERRON over 12 years ago
Tested and approved ! It's OK for me. Thanks Matthieu
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Pending technical review to Released
Awesome, thanks for testing guys.