Project

General

Profile

Actions
Copy link

Bug #2625

closed

The rudder-passwords.conf should now be generated and managed by the packaging

Added by Matthieu CERDA over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
2
Assignee:
Matthieu CERDA
Category:
System techniques
Target version:
2.4.0~beta3
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The rudder-passwords.conf should now be generated and managed by the packaging in rudder-server-root

Actions
Copy link
 #1

Updated by Matthieu CERDA over 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:b269d99286e34d750cfa3e516f957425b9d1377a.

Actions
Copy link
 #2

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Pending technical review to Discussion

This is much better, and the commit looks find, except for one thing: why did you remove the random password generation? This is a regression, it means we now will have static password all over again!

Actions
Copy link
 #3

Updated by Matthieu CERDA over 12 years ago

  • Assignee changed from Matthieu CERDA to Jonathan CLARKE

Well, I am copying a static file here.

Do you want that the file regenerates during the rudder-init as well ? (aka keep the previous file generation in rudder-init with password generation as well as the packaging initial version)

Actions
Copy link
 #4

Updated by Jonathan CLARKE over 12 years ago

Matthieu CERDA wrote:

Well, I am copying a static file here.

Do you want that the file regenerates during the rudder-init as well ? (aka keep the previous file generation in rudder-init with password generation as well as the packaging initial version)

What I want is simple:
  • All files should be owned by packaging
  • Passwords should be randomly generated
  • Rudder should work at all times :)

How it is implemented is up to you!

So, if you change passwords during rudder-init, you must make sure they are immediately applied to all config files - I assume a manual run of cf-agent would suffice.

Actions
Copy link
 #5

Updated by Matthieu CERDA over 12 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

Well, the discussion status of this ticket prevented the commits to close it automatically it seems. Oh well, I'm doing it manually then.

Actions
Copy link
 #6

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Pending technical review to Discussion

This looks good, aside from one anomaly: why this change? 

-if [ -e $LDAPDATA_PATH ]; then /etc/init.d/slapd start &> $TMP_LOG; fi
+if [ -e $LDAPDATA_PATH ]; then /etc/init.d/slapd restart &> $TMP_LOG; fi
. I don't see any reason for it, and it certainly is not related to this bug.

Actions
Copy link
 #7

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 47 to 50
Actions
Copy link
 #8

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 50 to 2.4.0~beta3
Actions
Copy link
 #9

Updated by Matthieu CERDA over 12 years ago

  • Assignee changed from Matthieu CERDA to Jonathan CLARKE

I thought it would be consistent with the precedent and following statements in the script.

You are right, it is certainly not relevant. Reverting this.

Actions
Copy link
 #10

Updated by Matthieu CERDA over 12 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
Actions
Copy link
 #11

Updated by Matthieu CERDA over 12 years ago

  • Status changed from In progress to Pending technical review

Applied in changeset commit:1e229ab70940b4aec1505f9814fdabfc5117204a.

Actions
Copy link
 #12

Updated by Nicolas PERRON over 12 years ago

It seems OK to me

Actions
Copy link
 #13

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Pending technical review to Released
Actions
Copy link

Also available in: Atom PDF