Project

General

Profile

Actions

Architecture #14291

closed

Remove deprecated (and not use) code causing warning

Added by François ARMAND almost 6 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Internal libs
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

In scala-ldap, we are using a old, deprecated piece of code to double-check a property on nodes in a LDAP tree.
That code cause warning and actually does nothing else than testing for a requirement, which can be done elsewhere without the deprecated code.
Moreover, the test is done with a "require" (ie an assert), so it would just explose in a stack trace.

I propose to let the old code in 4.1 to avoid any risk and correct it above: now that we have merged repos, we are going to see the warning more frequently.

Actions #1

Updated by François ARMAND almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/2137
Actions #2

Updated by Rudder Quality Assistant almost 6 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #3

Updated by François ARMAND almost 6 years ago

  • Status changed from Discussion to Pending release
Actions #4

Updated by François ARMAND almost 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.10 and 5.0.7 which were released today.

Actions

Also available in: Atom PDF