Bug #20834: File from shared folder method does not support special characters in the source path - Rudder - Issue Tracker

Actions

Copy link

Bug #20834

closed

File from shared folder method does not support special characters in the source path

Added by Félix DALLIDET almost 3 years ago. Updated over 1 year ago.

Status:

Released

Priority:

N/A

Assignee:

Félix DALLIDET

Category:

Relay server or API

Target version:

7.2.5

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Major - prevents use of part of Rudder | no simple workaround

UX impact:

I dislike using that feature

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Priority:

Name check:

To do

Fix check:

Checked

Regression:

Description

I had to deploy some binary files on windows nodes, and it worked fine for the 1st run, but after that, the hash check to compare the file on the server and node side failed everytime.
Renaming the file without any special chars fixed the issue.

It looks like the method and relayd do not encode the urls in the same manner.
With a file named: 'Firefox Setup 97.0.1.msi'
I ended up with the following errors:

&"C:\Program Files\Rudder\bin\curl.exe" --silent --tlsv1.2 --location --fail --show-error --cert "C:\Program Files\Rudder\etc\ssl\localhost.cert:Rudder-dsc passphra
se" --key "C:\Program Files\Rudder\etc\ssl\localhost.priv"  --insecure --user "rudder:708c6b5e36db18302e2c" "--head" "https://192.168.21.2/rudder/relay-api/shared-folder/Firefox%20Setup%2097.0.1.msi?hash=605ae210ab01363b2c7c773a3d2bea1ab1d6d1a1bfa26f5389bfe7b32fdb76f1&hash_type=sh
a256" 
curl: (22) The requested URL returned error: 404 Not Found
    + CategoryInfo          : NotSpecified: (curl: (22) The ...: 404 Not Found:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
    + PSComputerName        : localhost

Mar 01 09:15:12 server rudder-relayd[392]:  INFO relayd::relay-api: 127.0.0.1:39650 "HEAD /rudder/relay-api/1/shared-folder/Firefox%20Setup%2097.0.1.msi HTTP/1.1" 404 "-" "curl/7.69.1" 82.86>
Mar 01 09:17:23 server rudder-relayd[392]:  INFO relayd: Configuration reload requested

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Alexis Mousset almost 3 years ago

Project changed from 78 to Rudder
Category changed from Generic methods to Relay server or API
Target version changed from 6.2-1.27 to 6.2.13

Actions

Copy link

Updated by Alexis Mousset almost 3 years ago

Assignee set to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset almost 3 years ago

It is especially important on Windows where e.g. installers sometimes have spaces in their name.

Actions

Copy link

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.2.13 to 6.2.14

Actions

Copy link

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.2.14 to 6.2.15

Actions

Copy link

Updated by Alexis Mousset over 2 years ago

Severity changed from Minor - inconvenience | misleading | easy workaround to Major - prevents use of part of Rudder | no simple workaround
UX impact set to I dislike using that feature
User visibility set to Operational - other Techniques | Rudder settings | Plugins
Priority changed from 0 to 50