Project

General

Profile

Actions

Bug #20834

closed

File from shared folder method does not support special characters in the source path

Added by Félix DALLIDET about 2 years ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Relay server or API
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
I dislike using that feature
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Priority:
63
Name check:
To do
Fix check:
Checked
Regression:
No

Description

I had to deploy some binary files on windows nodes, and it worked fine for the 1st run, but after that, the hash check to compare the file on the server and node side failed everytime.
Renaming the file without any special chars fixed the issue.

It looks like the method and relayd do not encode the urls in the same manner.
With a file named: 'Firefox Setup 97.0.1.msi'
I ended up with the following errors:

&"C:\Program Files\Rudder\bin\curl.exe" --silent --tlsv1.2 --location --fail --show-error --cert "C:\Program Files\Rudder\etc\ssl\localhost.cert:Rudder-dsc passphra
se" --key "C:\Program Files\Rudder\etc\ssl\localhost.priv"  --insecure --user "rudder:708c6b5e36db18302e2c" "--head" "https://192.168.21.2/rudder/relay-api/shared-folder/Firefox%20Setup%2097.0.1.msi?hash=605ae210ab01363b2c7c773a3d2bea1ab1d6d1a1bfa26f5389bfe7b32fdb76f1&hash_type=sh
a256" 
curl: (22) The requested URL returned error: 404 Not Found
    + CategoryInfo          : NotSpecified: (curl: (22) The ...: 404 Not Found:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
    + PSComputerName        : localhost


Mar 01 09:15:12 server rudder-relayd[392]:  INFO relayd::relay-api: 127.0.0.1:39650 "HEAD /rudder/relay-api/1/shared-folder/Firefox%20Setup%2097.0.1.msi HTTP/1.1" 404 "-" "curl/7.69.1" 82.86>
Mar 01 09:17:23 server rudder-relayd[392]:  INFO relayd: Configuration reload requested


Subtasks 1 (0 open1 closed)

Bug #22404: Rhel7 builds fails due to a file with spaces in its nameReleasedAlexis MoussetActions
Actions #1

Updated by Alexis Mousset about 2 years ago

  • Project changed from 78 to Rudder
  • Category changed from Generic methods to Relay server or API
  • Target version changed from 6.2-1.27 to 6.2.13
Actions #2

Updated by Alexis Mousset about 2 years ago

  • Assignee set to Alexis Mousset
Actions #3

Updated by Alexis Mousset about 2 years ago

It is especially important on Windows where e.g. installers sometimes have spaces in their name.

Actions #4

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 6.2.13 to 6.2.14
Actions #5

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.2.14 to 6.2.15
Actions #6

Updated by Alexis Mousset almost 2 years ago

  • Severity changed from Minor - inconvenience | misleading | easy workaround to Major - prevents use of part of Rudder | no simple workaround
  • UX impact set to I dislike using that feature
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Priority changed from 0 to 50

This is quite serious.

Actions #7

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.2.15 to 6.2.16
  • Priority changed from 50 to 49
Actions #8

Updated by Alexis Mousset over 1 year ago

  • Target version changed from 6.2.16 to 6.2.17
Actions #9

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 6.2.17 to 997
  • Priority changed from 49 to 70
Actions #10

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 997 to 6.2.18
Actions #11

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 6.2.18 to 6.2.19
Actions #12

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 6.2.19 to 6.2.20
Actions #13

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 6.2.20 to old 6.2 issues to relocate
  • Priority changed from 70 to 68
Actions #14

Updated by Alexis Mousset about 1 year ago

  • Target version changed from old 6.2 issues to relocate to 7.2.5
  • Priority changed from 68 to 63
  • Regression set to No
Actions #15

Updated by Alexis Mousset about 1 year ago

  • Status changed from New to In progress
Actions #16

Updated by Alexis Mousset about 1 year ago

This is due to https://github.com/seanmonstar/warp/issues/242, the path fragments are not automatically URL-decoded.

Actions #17

Updated by Alexis Mousset about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Félix DALLIDET
  • Pull Request set to https://github.com/Normation/rudder/pull/4667
Actions #18

Updated by Alexis Mousset about 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #19

Updated by Vincent MEMBRÉ about 1 year ago

  • Subtask #22404 added
Actions #20

Updated by Félix DALLIDET about 1 year ago

  • Fix check changed from To do to Checked
Actions #21

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.2.5 which was released today.

Actions

Also available in: Atom PDF