Project

General

Profile

Actions
Copy link

Architecture #2135

closed

Factor out all JS pop-up

Added by Arthur ANGLADE almost 13 years ago. Updated almost 13 years ago.

Status:
Released
Priority:
N/A
Assignee:
Arthur ANGLADE
Category:
Architecture - Code maintenance
Target version:
2.4.0~alpha2
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

the same code was copy-pasted to create all popups in scala, it needs to be factorized

Actions
Copy link
 #1

Updated by Arthur ANGLADE almost 13 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by Jonathan CLARKE almost 13 years ago

  • Category set to Architecture - Code maintenance
Actions
Copy link
 #3

Updated by François ARMAND almost 13 years ago

  • Status changed from Pending technical review to 10

Technical review seems ok.

Actions
Copy link
 #4

Updated by Jonathan CLARKE almost 13 years ago

  • Status changed from 10 to Released

Closing these "Architecture" issues without a functional review - this step of the workflow has no sense here, there is no functional impact on code architecture changes (or there shouldn't be anyway!).

I think we should remove this step from the workflow for Architecture issues.

Actions
Copy link

Also available in: Atom PDF