Actions
Bug #22287
closed'rudder' global parameters is generated as a string containing json and not as a json
Pull Request:
Severity:
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No
Description
The parameter is of JSON type, this can be seen in the UI in the node inherited properties for instance.
But, in the generated files, we end up with:
root@server:/var/rudder/cfengine-community/inputs# cat rudder-parameters.json { "parameters":{ "rudder":"{\"log\":{\"syslog_facility\":\"NONE\"},\"packages\":{\"installed_cache_expire\":60,\"updates_cache_expire\":240},\"server\":{\"cf_serverd_bind_address\":\"::\"}}", "rudder_file_edit_header":"### Managed by Rudder, edit with care ###" } }
Wich is a json encapsulated in a string and not a Json at all. In the properies, it is correctly rendered:
root@server:/var/rudder/cfengine-community/inputs# cat properties.d/properties.json { "properties":{ "rudder":{ "log":{ "syslog_facility":"NONE" }, "packages":{ "installed_cache_expire":60, "updates_cache_expire":240 }, "server":{ "cf_serverd_bind_address":"::" } }, "rudder_file_edit_header":"### Managed by Rudder, edit with care ###" } }
I did not look for what it can break but it is not consistent. I am pretty sure we now use the property instead of the parameter almost everywhere so it is most likely not a big issue, still odd.
Updated by Vincent MEMBRÉ almost 2 years ago
- Target version changed from 7.3.0~beta1 to 7.3.0~rc1
Updated by Alexis Mousset almost 2 years ago
- Status changed from New to Rejected
It is not documented anymore and there only for compatibility.
We won't break the compatibility at this point, closing.
Actions