Project

General

Profile

Actions

Bug #2404

closed

update group container in an existed group

Added by Francois BAYART over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Nodes & inventories
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I have created a group named "ZZZ1 - users" and after I would like to change it to a new created group category named "ZZZ1"; so I click on the group "ZZZ1 - users" change the group container and I click on update. => no change

so I click on the group "ZZZ1 - users" change the group container, click on search and I click on update. => no change

after each "click update" I make a new test like click on "search nodes" and click on "groups" just in case.


Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #2466: Moving node from a group to another works with drag n drop but not with changing "Group container"RejectedFrançois ARMAND2012-04-23Actions
Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Priority changed from N/A to 1 (highest)
  • Target version set to 2.3.7

Er, why has this bug not been addressed!?

Actions #2

Updated by François ARMAND over 12 years ago

  • Status changed from New to In progress
Actions #3

Updated by François ARMAND over 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100
Actions #4

Updated by Jonathan CLARKE over 12 years ago

This one should be reviewed by Nicolas, but he's on holiday and we need it sooner.

So, I've taken a look, although I'm no Scala expert, I can confirm that:
  • This commit is clean, and doesn't change anything that looks suspicious
  • The updateGroup method that was changed is not used anywhere else in the code, so this shouldn't break it
  • Functionally, using the application, this now works as expected

So AFAICT, this is good.

Actions #5

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to Released
Actions

Also available in: Atom PDF