Bug #2417
closed
checkGenericFileContent 2.1 is highly dubious
Description
It used to be multin instance, it isn't anymore. This is highly dubious, since 2.0 is multivalued.
It's been mcreated by tickets 2140 and 2218, without any multi instance within...
Updated by Jonathan CLARKE over 12 years ago
- Priority changed from N/A to 1 (highest)
Updated by Matthieu CERDA over 12 years ago
Can you please describe a bit further what is the problem here ? I far as I can see, the 2.1 version of the PT in the 2.3 repo is perfectly fine: https://github.com/Normation/rudder-techniques/blob/branches/rudder/2.3/policies/fileDistribution/checkGenericFileContent/2.1/checkGenericFileContent.st and https://github.com/Normation/rudder-techniques/blob/branches/rudder/2.3/policies/fileDistribution/checkGenericFileContent/2.1/policy.xml
What is the problem ?
Updated by Matthieu CERDA over 12 years ago
- Status changed from New to Discussion
- Assignee changed from Matthieu CERDA to Nicolas CHARLES
Updated by Nicolas CHARLES over 12 years ago
The PT used to have a "Add another" button, which is not the case anymore
Previous version, as per commit ea8f29020bbe205615c751b180c5aaf5ece92288
<SECTION name="File to manage" multivalued="true"> <SECTION name="File" component="true" componentKey="GENERIC_FILE_CONTENT_PATH">
New version, in the repository
<SECTION name="File to manage"> <SECTION name="File" component="true">
So the version is far from being perfectly fine ...
Updated by Matthieu CERDA over 12 years ago
- Status changed from Discussion to In progress
- % Done changed from 0 to 80
You are right NCH, but I just can't understand why this commit was not applied on this branch ... maybe a merge error !
Anyway, I cherry picked the commit, I will now test it on Orch-2.
Updated by Matthieu CERDA over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 80 to 100
With commit:ea8f29020bbe205615c751b180c5aaf5ece92288 , the "Add another" button is there and the PT behaves OK. I think I'm done here !
Updated by Nicolas PERRON
Updated by Nicolas CHARLES over 12 years ago
- Status changed from Pending technical review to Released
This looks correct, thank you