Project

General

Profile

Actions

User story #2493

closed

Add reasons field to Directives edit form

Added by Jean VILVER over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jean VILVER
Category:
Web - Config management
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Related issues 1 (0 open1 closed)

Blocks Rudder - User story #2399: Change message for configuration changesReleasedFrançois ARMAND2012-04-02Actions
Actions #1

Updated by Anonymous over 12 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions #2

Updated by Jonathan CLARKE over 12 years ago

  • Target version set to 2.4.0~alpha7
Actions #3

Updated by François ARMAND over 12 years ago

  • Priority changed from N/A to 1 (highest)

That seems OK, even if the commits are strange. I'm wondering why the first two are identicals...

Actions #4

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to 10
Actions #5

Updated by Jonathan CLARKE over 12 years ago

  • Category set to Web - Config management
  • Status changed from 10 to Discussion

This does not seem to work as expected. I just used a freshly installed version of Rudder (so with default config parameters), edited a Directive, and saved. I got a popup saying "Your changes have been saved", but then the screen returned to the previous display and a red error message saying "The reasons must have at least 5 characters" was displayed.

This should not appear if the message is not mandatory, and should appear before the confirmation popup if it is mandatory.

Actions #6

Updated by Jean VILVER over 12 years ago

That should be Ok now, this problem was fixed with #2492.

Jonathan CLARKE wrote:

This does not seem to work as expected. I just used a freshly installed version of Rudder (so with default config parameters), edited a Directive, and saved. I got a popup saying "Your changes have been saved", but then the screen returned to the previous display and a red error message saying "The reasons must have at least 5 characters" was displayed.

This should not appear if the message is not mandatory, and should appear before the confirmation popup if it is mandatory.

Actions #7

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Discussion to Released

Jonathan CLARKE wrote:

This does not seem to work as expected. I just used a freshly installed version of Rudder (so with default config parameters), edited a Directive, and saved. I got a popup saying "Your changes have been saved", but then the screen returned to the previous display and a red error message saying "The reasons must have at least 5 characters" was displayed.

This should not appear if the message is not mandatory, and should appear before the confirmation popup if it is mandatory.

Jean Vilver wrote:

That should be Ok now, this problem was fixed with #2492.

This is indeed fixed, thanks Jean.

Actions

Also available in: Atom PDF