Bug #2664: An "Rule modified" event log with a target change is not displayed correctly - Rudder - Issue Tracker

Actions

Copy link

Bug #2664

closed

An "Rule modified" event log with a target change is not displayed correctly

Added by Jean VILVER almost 12 years ago. Updated over 11 years ago.

Status:

Released

Priority:

N/A

Assignee:

Jean VILVER

Category:

Web - Maintenance

Target version:

2.4.0~beta3

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

We should see a formated description of the change before the reason message.

Files

rule_modified_problem.png (23.4 KB) rule_modified_problem.png

Jean VILVER, 2012-07-18 16:31

Actions

Copy link

Updated by Jean VILVER almost 12 years ago

Description updated (diff)

Actions

Copy link

Updated by Jean VILVER almost 12 years ago

Status changed from New to Pending technical review
% Done changed from 0 to 100

Applied in changeset ae83b21241d36ad908b6fb636d7c3933305b3402.

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Status changed from Pending technical review to Discussion
% Done changed from 100 to 90

Jean, I'm not sure about the modification in the file EventLogDetailsService. The serialization of a Rule has a "targets" node, and within this node there are "target" nodes; however, you are looking for rule \ "target" rather that rule \ "targets". Could you explain why ?
Thank you!

Actions

Copy link

Updated by Jean VILVER over 11 years ago

Status changed from Discussion to Pending technical review

Nicolas CHARLES wrote:

Jean, I'm not sure about the modification in the file EventLogDetailsService. The serialization of a Rule has a "targets" node, and within this node there are "target" nodes; however, you are looking for rule \ "target" rather that rule \ "targets". Could you explain why ?
Thank you!

It's fixed in 60f53ca9471582e122ea2869fa7b955180eb9079.

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Status changed from Pending technical review to In progress
% Done changed from 90 to 80

val l = group.serverList.toSeq
l match {
  case Nil => Text("None")

won't work ! You can't properly match Nil with a Seq as Nil extends List[Nothing], and List extends LinearSeq, which extends Seq.
If you are unsure about why it shouldn't work, replace "Nil" by "EmptyCar", List[Nothing] by Car[Nothing], LinearSeq by VehiculeWith4Wheels, and Seq by Vehicule
The probability that the Vehicule your are matching the an EmptyCar is very little

Actions

Copy link