Architecture #2765
closedIn rudder_lib.st are two differents classes which do the same things.
Description
It seems that in rudder_lib.st are a duplicate class:
[...] body classes kept_if_else(kept, yes,no) { promise_kept => { "$(kept)" }; promise_repaired => { "$(yes)" }; repair_failed => { "$(no)" }; repair_denied => { "$(no)" }; repair_timeout => { "$(no)" }; } [..] body classes class_trigger(if,else,kept) { promise_kept => { "$(kept)" }; promise_repaired => { "$(if)" }; repair_failed => { "$(else)" }; repair_denied => { "$(else)" }; repair_timeout => { "$(else)" }; } [...]
We should use one or another but not both of them.
Updated by Nicolas PERRON over 12 years ago
- Tracker changed from Bug to Architecture
This is not a bug but an architecture. I'm not sure to keep this issue in 2.4.
Updated by Jonathan CLARKE over 12 years ago
- Assignee changed from Nicolas PERRON to Nicolas CHARLES
- Target version changed from 2.4.0~beta4 to 2.4.0~beta5
We should never delete any bodies, just mark one as deprecated. And update any Techniques that use the newly deprecated one.
Updated by Nicolas CHARLES over 12 years ago
- Status changed from New to In progress
Updated by Nicolas CHARLES over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 0 to 100
Applied in changeset commit:de480172e2afa204d252eff7cb11128b1517d037.
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Pending technical review to Released
Just looked at this and there was one typo in the changes (in downloadFile/1.0). Fixing, but otherwise this is fine.
Updated by Jonathan CLARKE over 12 years ago
That was in commit:6acb00c, by the way (see http://www.rudder-project.org/redmine/projects/policy-templates/repository/revisions/6acb00c).
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Released to Pending technical review
- Assignee changed from Nicolas CHARLES to Nicolas PERRON
The script I just commited needs a technical review please Nicolas.
Updated by Nicolas PERRON over 12 years ago
Jonathan CLARKE wrote:
The script I just commited needs a technical review please Nicolas.
Good idea to check the call of this class. This code seems valid to me !
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Pending technical review to Released