Project

General

Profile

Actions

Architecture #2765

closed

In rudder_lib.st are two differents classes which do the same things.

Architecture #2765: In rudder_lib.st are two differents classes which do the same things.

Added by Nicolas PERRON over 13 years ago. Updated about 13 years ago.

Status:
Released
Priority:
3
Assignee:
Nicolas PERRON
Category:
System techniques
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

It seems that in rudder_lib.st are a duplicate class:

[...]
body classes kept_if_else(kept, yes,no)

{
promise_kept     => { "$(kept)" };
promise_repaired => { "$(yes)" };
repair_failed    => { "$(no)" };
repair_denied    => { "$(no)" };
repair_timeout   => { "$(no)" };
}

[..]

body classes class_trigger(if,else,kept)
{
promise_kept => { "$(kept)" };
promise_repaired => { "$(if)" };
repair_failed => { "$(else)" };
repair_denied    => { "$(else)" };
repair_timeout   => { "$(else)" };
}
[...]

We should use one or another but not both of them.

Updated by Nicolas PERRON about 13 years ago Actions #1

  • Tracker changed from Bug to Architecture

This is not a bug but an architecture. I'm not sure to keep this issue in 2.4.

Updated by Jonathan CLARKE about 13 years ago Actions #2

  • Assignee changed from Nicolas PERRON to Nicolas CHARLES
  • Target version changed from 2.4.0~beta4 to 2.4.0~beta5

We should never delete any bodies, just mark one as deprecated. And update any Techniques that use the newly deprecated one.

Updated by Nicolas CHARLES about 13 years ago Actions #3

  • Status changed from New to In progress

Updated by Nicolas CHARLES about 13 years ago Actions #4

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:de480172e2afa204d252eff7cb11128b1517d037.

Updated by Jonathan CLARKE about 13 years ago Actions #5

  • Status changed from Pending technical review to Released

Just looked at this and there was one typo in the changes (in downloadFile/1.0). Fixing, but otherwise this is fine.

Updated by Jonathan CLARKE about 13 years ago Actions #6

Updated by Jonathan CLARKE about 13 years ago Actions #7

  • Status changed from Released to Pending technical review
  • Assignee changed from Nicolas CHARLES to Nicolas PERRON

The script I just commited needs a technical review please Nicolas.

Updated by Nicolas PERRON about 13 years ago Actions #8

Jonathan CLARKE wrote:

The script I just commited needs a technical review please Nicolas.

Good idea to check the call of this class. This code seems valid to me !

Updated by Jonathan CLARKE about 13 years ago Actions #9

  • Status changed from Pending technical review to Released
Actions

Also available in: PDF Atom