Project

General

Profile

Actions

Bug #2789

closed

In rudder-upgrade, if the migration from policy-templates to techniques fails, it is no more possible to upgrade and nothing happens

Added by Nicolas PERRON over 12 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Nicolas PERRON
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The if statement of the upgrade from policy-templates to techniques is not enough supple. It only checks that /var/rudder/configuration-repositories/techniques doesn't exist and only then upgrade.

Actions #1

Updated by Nicolas PERRON over 12 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:d468eaf2b4d52aaee116f809c6c608a50a55e93f.

Actions #2

Updated by Matthieu CERDA over 12 years ago

Looks good to me.

Actions #3

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Pending technical review to Released

This makes complete sense, nice catch.

However, the "else" statement you have added to say "WARNING: You have both /var/rudder/configuration-repository/policy-templates (obsoletes) and /var/rudder/configuration-repository/techniques (new) folders" is illogical. The message is displayed whenever the migration has already been done, even when /var/rudder/configuration-repository/policy-templates doesn't exist. I'm going to protect it with a more correct if statement.

Actions #4

Updated by Nicolas PERRON almost 12 years ago

  • Project changed from Rudder to 34
  • Category deleted (11)
Actions #5

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF