Bug #2822
closed
A rudder upgrade does not add a default role to users in rudder-users.xml if they were admins in 2.3
Description
A rudder upgrade does not replace rudder-users.xml if it has been modified, we should take care of adding entries like 'role="administrator"' to the users in this file to prevent the user from seeing a totally useless Rudder home without any features.
Updated by Jonathan CLARKE over 12 years ago
- Subject changed from A rudder upgrade does not replace rudder-users.xml if it has been modified to A rudder upgrade does not add a default role to users in rudder-users.xml if they were admins in 2.3
Updated by Jonathan CLARKE over 12 years ago
- Status changed from New to 2
- Priority changed from 2 to 1 (highest)
- Target version changed from 2.4.0~beta4 to 2.4.0~beta5
This should be implemented by adding a comment line to rudder-users.xml like "# This file was migrated from 2.3 to 2.4 by adding the admin role to all users. Don't delete this line or it will happen again!", and testing for that line's presence on each upgrade.
Updated by Nicolas PERRON over 12 years ago
Jonathan CLARKE wrote:
It should be two kind of comments:This should be implemented by adding a comment line to rudder-users.xml like "# This file was migrated from 2.3 to 2.4 by adding the admin role to all users. Don't delete this line or it will happen again!", and testing for that line's presence on each upgrade.
- migrated file: __
- not migrated file: __
The rudder-upgrade script file could be executed several times and even if this is a fresh 2.4 installation. Do you agree ?
Updated by Jonathan CLARKE over 12 years ago
Nicolas PERRON wrote:
Jonathan CLARKE wrote:
It should be two kind of comments:This should be implemented by adding a comment line to rudder-users.xml like "# This file was migrated from 2.3 to 2.4 by adding the admin role to all users. Don't delete this line or it will happen again!", and testing for that line's presence on each upgrade.
- migrated file: __
- not migrated file: __
The rudder-upgrade script file could be executed several times and even if this is a fresh 2.4 installation. Do you agree ?
Agreed!
At least in principle - for future compatibility, I think the second comment should be "This file was originally made from Rudder 2.4 or later", so we don't have to change this when using 2.5...
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 2.4.0~beta5 to 2.4.0~rc1
Updated by Nicolas PERRON over 12 years ago
- Status changed from 2 to In progress
- % Done changed from 0 to 90
the last commit need a condition to not upgrade users which could contain "role" (even if should not happends from a Rudder 2.3 version)
Updated by Nicolas PERRON over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 90 to 100
Nicolas PERRON wrote:
the last commit need a condition to not upgrade users which could contain "role" (even if should not happends from a Rudder 2.3 version)
This is done. All seems alright. Only need Technical Review, now.
Updated by Nicolas PERRON over 12 years ago
- Target version changed from 2.4.0~rc1 to 2.4.0~beta5
Updated by Jonathan CLARKE over 12 years ago
- Status changed from Pending technical review to Released
I adjusted the regexp slightly to be a little more robust, but this looks good.
Updated by Nicolas PERRON almost 12 years ago
- Project changed from Rudder to 34
- Category deleted (
11)
Updated by Benoît PECCATTE almost 10 years ago
- Project changed from 34 to Rudder
- Category set to Packaging