Project

General

Profile

Actions

Bug #2829

closed

On Rudder 2.4.0~beta3, in distributePolicy/1.0/initCheck.st the init script for rudder-agent consider that CFEngine process are always running

Added by Nicolas PERRON over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
4
Assignee:
Jonathan CLARKE
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Even if no CFEngine process is up, initCheck.cf promise will consider that CFEngine is running:

sles1164test:~# /etc/init.d/rudder-agent stop
rudder-agent[20908]: [INFO] Using /etc/default/rudder-agent for configuration
rudder-agent[20912]: [INFO] Using /var/rudder/cfengine-community for CFEngine workdir
rudder-agent[20913]: [INFO] Halting CFEngine Community cf-serverd...
rudder-agent[20917]: [OK] CFEngine Community cf-serverd stopped after 2 seconds
rudder-agent[20918]: [INFO] Halting CFEngine Community cf-execd...
rudder-agent[20922]: [OK] CFEngine Community cf-execd stopped after 2 seconds

sles1164test:~# ps axf | grep cf
20924 pts/0    S+     0:00  |       \_ grep cf

sles1164test:/var/rudder/configuration-repository/techniques/system/distributePolicy/1.0 # /var/rudder/cfengine-community/bin/cf-agent -KI -b root_init_check
 !! Duplicate selection of value for variable "execRun" in scope g
 !! Rule from /var/rudder/cfengine-community/inputs/common/1.0/site.cf at/before line 58
 !! Duplicate selection of value for variable "execRun" in scope g
 !! Rule from /var/rudder/cfengine-community/inputs/motdConfiguration/1.0/motdConfiguration.cf at/before line 79
 >> Using command line specified bundlesequence
R: @@DistributePolicy@@result_success@@root-DP@@root-distributePolicy@@35@@Check postgresql process@@None@@2012-08-20 18:05:03+02:00##root@#The postgresql process is already running
R: @@DistributePolicy@@result_success@@root-DP@@root-distributePolicy@@35@@Check jetty process@@None@@2012-08-20 18:05:03+02:00##root@#The jetty process is already running
R: @@DistributePolicy@@result_success@@root-DP@@root-distributePolicy@@35@@Check slapd process@@None@@2012-08-20 18:05:03+02:00##root@#The slapd process is already running
R: @@DistributePolicy@@result_success@@root-DP@@root-distributePolicy@@35@@Check apache2 process@@None@@2012-08-20 18:05:03+02:00##root@#The apache2 process is already running
R: @@DistributePolicy@@result_success@@root-DP@@root-distributePolicy@@35@@Check rudder-agent process@@None@@2012-08-20 18:05:03+02:00##root@#The rudder-agent process is already running
[...]

It seems that this is because the processes checked are /var/rudder/cfengine-community/bin/cf-.* and when cf-agent is launched, the process is matched. This test seems useless.

Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from In progress to Discussion
  • Assignee changed from Nicolas PERRON to Jonathan CLARKE
  • Target version changed from 2.4.0~beta4 to 2.4.0~beta5

I'll look into this and see if I can find any logic in what appears to be a process checking that it itself is running...

Actions #2

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~beta5 to 2.4.0~rc1
Actions #3

Updated by Jonathan CLARKE over 12 years ago

This check is not needed here, as it already covered by the check_cf_processes bundle in promises.cf. I'm removing it.

Actions #4

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from Discussion to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:141bb711bc37b8793a717d64a04ebcc8b6a22160.

Actions #5

Updated by Nicolas PERRON over 12 years ago

It looks good to me.

Actions #6

Updated by Nicolas PERRON about 12 years ago

  • Target version changed from 2.4.0~rc1 to 2.4.0~beta5
Actions #7

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to Released

This looks valid, thank you guys

Actions

Also available in: Atom PDF