User story #3343: Installation script should check if launched in bash - Rudder - Issue Tracker

Actions

Copy link

User story #3343

closed

Installation script should check if launched in bash

Added by Arthur ANGLADE over 11 years ago. Updated almost 7 years ago.

Status:

Rejected

Priority:

Assignee:

Category:

Packaging

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

the installation script works on bash; if launched by "sh .......blahlah.sh", shouldn't it be detected and relaunched under bash ?

Actions

Copy link

Updated by Matthieu CERDA over 11 years ago

Status changed from New to Discussion
Assignee changed from Matthieu CERDA to Jonathan CLARKE

After some thinking, some ideas I got:

Stop calling this script rudder-init.sh, should be rudder-init without extension. It confuses some users and .bash is not a very common extension ... Also, on UNIX .sh is not really useful.
Make the documentation more clear.

I do not think that some detection logic should be added on the script, as current interpreter detection is either not portable/not reliable/full of traps (/bin/sh symlinked to bash on lots of systems)/ ...

Actions

Copy link

Updated by Matthieu CERDA over 11 years ago

Wnat should we do then ?

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.6.0~beta1 to 2.6.0~rc1

Actions

Copy link

Updated by Matthieu CERDA over 11 years ago

Target version changed from 2.6.0~rc1 to 2.6.0

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Target version changed from 2.6.0 to 2.6.1

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.6.1 to 2.6.2

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.6.2 to 2.6.3

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.6.3 to 2.6.4

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Assignee changed from Jonathan CLARKE to Matthieu CERDA

Matthieu CERDA wrote:

After some thinking, some ideas I got:

Stop calling this script rudder-init.sh, should be rudder-init without extension. It confuses some users and .bash is not a very common extension ... Also, on UNIX .sh is not really useful.

Make the documentation more clear.

Agreed.

I do not think that some detection logic should be added on the script, as current interpreter detection is either not portable/not reliable/full of traps (/bin/sh symlinked to bash on lots of systems)/ ...

OK.

Actions

Copy link

#10