Project

General

Profile

Actions
Copy link

Bug #4686

closed

Typo in /opt/rudder/bin/check-rudder-agent, prevent cleaning of cf-lock and floods with cron mails

Bug #4686: Typo in /opt/rudder/bin/check-rudder-agent, prevent cleaning of cf-lock and floods with cron mails

Added by Dennis Cabooter about 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
System integration
Target version:
2.9.5
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

For some reason, I often get cron mails from various servers at various times with the following content:

WARNING: The file /var/rudder/cfengine-community/last_successful_inputs_update is older than 10 minutes, the agent is probably stuck. Purging the TokyoCabinet lock file... Done

In the past if a server was in NoAnswer state, I did a manual "find /var/rudder -name '*tcdb*' -delete". That was annoying, but the cron implementation is even more annoying. If i'm awafor the weekend, I will have 1000+ mails on monday. Disable cron mail is no option, cause then /var/spool/mail will grow very fast and I don't know what's happening on nodes. Please find another solution! Thanks in advance.

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #4752: cf_lock.tcdb is not cleaned by check-rudder-agent script when update file is older than 10 minutesReleasedJonathan CLARKEActions
Related to Rudder - Bug #4769: rudder-agent may be stucked by tokyo cabinet database bloatingReleasedJonathan CLARKEActions

Updated by Vincent MEMBRÉ about 12 years ago Actions
Copy link
 #1

  • Subject changed from Cron mail flood to typo in /opt/rudder/bin/check-rudder-agent, making locks not cleaned and cron flooding with mails
  • Category set to System integration
  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ

There is a typo in check-rudder-agent, where tcdb is written tdcb

./rudder-agent/SOURCES/check-rudder-agent:82:  rm -f ${CFE_DIR}/state/cf_lock.tdcb
./rudder-agent/SOURCES/check-rudder-agent:83:  rm -f ${CFE_DIR}/state/cf_lock.tdcb.lock

so the lock stays here and the problem is not fixed and detected at every cron run.

Fixing it will fix both problems (mail flood and tcdb cleaning)

Updated by Vincent MEMBRÉ about 12 years ago Actions
Copy link
 #2

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/297

Updated by Vincent MEMBRÉ about 12 years ago Actions
Copy link
 #3

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset packages:commit:71ea7eb3f1df9941de393b42624c28e27e01b557.

Updated by Matthieu CERDA about 12 years ago Actions
Copy link
 #4

Applied in changeset packages:commit:44aa769b04d29a5704fb0945db2f6263034122c5.

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
 #5

  • Subject changed from typo in /opt/rudder/bin/check-rudder-agent, making locks not cleaned and cron flooding with mails to Typo in /opt/rudder/bin/check-rudder-agent, prevent cleaning of cf-lock and floods with cron mails

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
 #6

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.9.5 (announcement , changelog) and 2.10.1 (announcement , changelog), which were released today.

Actions
Copy link

Also available in: PDF Atom