Project

General

Profile

Bug #5564

Tools folder are empty!

Added by Nicolas CHARLES over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
1
Category:
System techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

In #5459, we introduced a mecanism to prevent copy of tools if they were not updated; however it seems there is a problem, as the tools are never copied, nly the update file is copied !


Related issues

Related to Rudder - Bug #5459: Tools directory is not always correctly updated on nodesReleased2014-09-01Jonathan CLARKEActions
#1

Updated by Nicolas CHARLES over 5 years ago

ok, the cause was a poor attempt at optimizing (and I blame myself) don't mixing well with the fact that permissions are correct even at file creation, so it defines the class rudder_tools_updated_kept

Since copy is done only in failsafe (not in normal execution), there is no way (unless hammering manually the failsafe) that multiple copies will occurs of the same files

So the fix is to remove this poor optimization

#2

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/508/files
#3

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:709f88a8722393d260fd5457e5ea916284eba2c6.

#4

Updated by Jonathan CLARKE over 5 years ago

Applied in changeset policy-templates:commit:94b4ebf436b106df74876b3c16e16dd5149b003f.

#5

Updated by Matthieu CERDA over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.6, which was released today.
Check out:

#6

Updated by Matthieu CERDA over 5 years ago

This bug has been fixed in Rudder 2.10.6, which was released today.
Check out:

Also available in: Atom PDF