Project

General

Profile

Actions

Bug #8829

closed

New method calls are considered valid, although they are empty which leads to error when validated via API

Added by Vincent MEMBRÉ about 6 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Web - Technique editor
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

When adding a new method in a Technique in ncf editor, without

Form is initialized with 'undefined' value which are considered valid on the UI part (which should not) so save button is activated (and should not)

Clicking on that button we got an error on the API which fails when calling a regexp search on a None value which is impossible ... that'a a python error, and very confusing, we should a message every one can understand (by checing if the value is None before checking it)

Actions #1

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from New to In progress
Actions #2

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/ncf/pull/418
Actions #3

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:44fd46bdfac35d55d571375266a6178b79a09c47.

Actions #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in ncf version bundled with Rudder 2.11.24, 3.1.13 and 3.2.6 which were released today.

Actions #5

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #6

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category changed from Technique editor - UI/UX to Web - Technique editor
Actions

Also available in: Atom PDF