Enhancement #23045
Updated by François ARMAND about 1 year ago
Git management is complicated, and even with automatic GC, commiting all node information in `/var/rudder/fact-repository/nodes` is not working for high load and without manual maintenance. So it breaks rudder at unexpected point:
- it can make change longer to be processed, like parsing a new inventory or changing a node property, due to long git commit time,
- it can lead to hard to diagnose errors due to git lock problem, like in #20355 or #22616 - which is also a prove that in any case, we need to become better at automatic git ops in rudder
- maybe it's linked with strange inventory problems (#22246)
As for now, and contrary to config-repository, that repo is not used for user-facing features, we should:
- add a config option to disable the commit part,
- make the default be "do not commit". *This means that by default, we won't have node property and inventory history stored*.
- make it in 7.3
CONFIG:
We have a new property available in @rudder-config.properties@ :
- @rudder.facts.repo.historizeNodeChange=false@ (default if not present) do not historise inventories in git
- @rudder.facts.repo.historizeNodeChange=true@ do commit inventories in git repos