Actions
Bug #10153
closedCalling twice file_ensure_key_value_present_in_ini_section for same file and section doesn't do anything for the second call
Status:
Released
Priority:
1 (highest)
Assignee:
Category:
Generic methods
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:
Description
(at least in CFEngine 3.10)
If we call twice file_ensure_key_value_present_in_ini_section, for same file and same section, it won't do anything, because it calls set_variable_values_ini("file_ensure_key_value_present_in_ini_section.content", "${section}")
Since only the content of "file_ensure_key_value_present_in_ini_section.content" changes, and it doesn't deep evaluates it, it won't run it the second time, and so skip the changes silently (verbose output doesn't even mention it)
We need to check all version impacted
Updated by Nicolas CHARLES almost 8 years ago
I tested in Rudder 3.1, and it already happens, so this issue has always been there
Updated by Nicolas CHARLES almost 8 years ago
- Status changed from New to In progress
- Assignee set to Nicolas CHARLES
Updated by Nicolas CHARLES almost 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Alexis Mousset
- Pull Request set to https://github.com/Normation/ncf/pull/527
Updated by Nicolas CHARLES almost 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset 20ff7bae0bc809546c357b5f894467f82c992a0e.
Updated by Vincent MEMBRÉ about 7 years ago
- Status changed from Pending release to Released
- Priority set to 0
Updated by Alexis Mousset over 2 years ago
- Target version changed from 0.x to ncf-0.x
Updated by Alexis Mousset over 2 years ago
- Project changed from 41 to Rudder
- Category changed from Generic methods to Generic methods
Actions