Project

General

Profile

Actions

Bug #10183

closed

Setting TTL to "30 minutes" in sharedfile to node generic method make it fail completly

Added by Nicolas CHARLES almost 8 years ago. Updated over 2 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

I tried to set the TTL to "30 minutes" for a shared file, and file could not be shared; I got the following error:

rudder     info: Executing 'no timeout' ... '/usr/bin/curl https://server/rudder/relay-api/shared-files/d3db571a-9659-4fc9-9230-e594cb9d65b4/82d806d8-1359-4d8f-a405-fe8cab062888/test?ttl=30 minutes?hash=0f343cc15c5a364f413912ad4588da403181627a31db80d72e82d4f660e773e86d7ba9f486e3d6254861bc898a830861d70629bef06ea888346f5082750607e9 -k -1 -L --head -o /dev/null -s -f '
rudder     info: Command related to promiser '/usr/bin/curl' returned code not defined as promise kept, not kept or repaired; setting to failed: 6
rudder     info: Completed execution of '/usr/bin/curl https://server/rudder/relay-api/shared-files/d3db571a-9659-4fc9-9230-e594cb9d65b4/82d806d8-1359-4d8f-a405-fe8cab062888/test?ttl=30 minutes?hash=0f343cc15c5a364f413912ad4588da403181627a31db80d72e82d4f660e773e86d7ba9f486e3d6254861bc898a830861d70629bef06ea888346f5082750607e9 -k -1 -L --head -o /dev/null -s -f '
R: [ERROR] Promise could not be repaired, error encountered: Unable to contact HTTP server on https://server/rudder/relay-api/shared-files/d3db571a-9659-4fc9-9230-e594cb9d65b4/82d806d8-1359-4d8f-a405-fe8cab062888/test?ttl=30 minutes from sharedfile_to_node
E| error         Share_file_from_agent1_t| Sharedfile to node        test              Unable to contact HTTP server on https://server/rudder/relay-api/shared-files/d3db571a-9659-4fc9-9230-e594cb9d65b4/82d806d8-1359-4d8f-a405-fe8cab062888/test?ttl=30 minutes from sharedfile_to_node could not be repaired
   error: Method 'sharedfile_to_node' failed in some repairs
   error: Method 'Share_file_from_agent1_to_agent2' failed in some repairs

Manually running the command causes:

root@agent1:/home/vagrant# /usr/bin/curl https://server/rudder/relay-api/shared-files/d3db571a-9659-4fc9-9230-e594cb9d65b4/82d806d8-1359-4d8f-a405-fe8cab062888/test?ttl=30 minutes?hash=0f343cc15c5a364f413912ad4588da403181627a31db80d72e82d4f660e773e86d7ba9f486e3d6254861bc898a830861d70629bef06ea888346f5082750607e9 -k -1 -L --head -o /dev/null -f
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 NOT FOUND
curl: (6) Couldn't resolve host 'minutes'

We should either prevent spaces, or sanitize entries


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #10296: Accept TTL with spaces in relay APIReleasedAlexis MoussetActions
Actions #1

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #2

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/543
Actions #3

Updated by Nicolas CHARLES almost 8 years ago

  • Related to Bug #10296: Accept TTL with spaces in relay API added
Actions #4

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:12599a29702e26908b09075722e241b3599353a1.

Actions #5

Updated by Vincent MEMBRÉ about 7 years ago

  • Status changed from Pending release to Released
  • Priority set to 0
Actions #6

Updated by Alexis Mousset over 2 years ago

  • Target version changed from master to ncf-1.2
Actions #7

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF