Project

General

Profile

Actions

Bug #10745

closed

Cannot generate promises when invalid character in a group name (double quote here)

Added by Josh Watt almost 4 years ago. Updated almost 4 years ago.

Status:
Released
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
0

Description

I created a group and assigned a rule to it, and my technique library then started throwing an error (actually, a lot of errors: https://pastebin.com/RZdVkWgr) after trying to refresh. Granted, the name I chose was terrible (i was very tired) - it was "Prod"-PHL (s1-pl***). I don't know if it was the double quotes, the space, the parenthesis, the hyphen, or the asterisks (again, i was tired) but it didn't like one of them. I renamed the group and all was right again.

Actions #1

Updated by Vincent MEMBRÉ almost 4 years ago

  • Subject changed from syntax checking when creating a group to Cannot generate promises when invalid character in a group name (double quote here)
  • Assignee set to Vincent MEMBRÉ
  • Target version set to 4.0.5
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Effort required set to Small

Thanks for reporting Josh!

Indeed the name is not very friendly but naming thing is hard ;)

that character should be allowed but we forgot to espace that quote when it generates a class for that group.

Escaping it in generation will fix this issue

Actions #2

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from New to In progress
Actions #3

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1654
Actions #4

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.5 and 4.1.2 which were released today.

Actions

Also available in: Atom PDF