Project

General

Profile

Actions

Bug #12834

closed

We need to explicit version of scala-library in plugin-parent else one is pick at random from transitive dependencies

Added by François ARMAND over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Dependencies
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

I definitly stop to try to understand how maven works.

So, for most dependencies, if you put them in "dependencyManagement" with scope "provided" but without version, maven takes the version in other Rudder project. But not for scala-library, where it seems to take the one from liftweb.

So in fact, I believe I just don't understand anything, and that maven just takes the first transitive dep it get, even if it's 4 version below other ones. Putting the verison in dependencyManagement does not seem to solve the problem (ie: if the version is in dependencyManagement, it does not affect transitive dependency resolution, so you need to put the dependency as a dependency (even if you keep version in dependencyManagmeent) to have the correct version resolved. This is madness).

I declare forfeit and start to read documentation about Bazel and Mill.

Actions #1

Updated by François ARMAND over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/44
Actions #2

Updated by François ARMAND over 5 years ago

In 4.1, it was not visible because of a non used dependency for test. We cleaned it up latter, breaking version resolution. Maven is an horror movie.

Actions #3

Updated by Rudder Quality Assistant over 5 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #4

Updated by François ARMAND over 5 years ago

  • Status changed from Discussion to Pending release
Actions #5

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Actions

Also available in: Atom PDF