Project

General

Profile

Actions

Bug #13887

closed

Option description for "File download (Rudder server)" technique is misleading

Added by François ARMAND over 2 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

'File download (Rudder server)' technique lets you copy things from `/var/rudder/configuration-repository/shared-files/` to somewhere else.

You have three option to choose what to copy:

- Only this file
- The whole content of the folder
- The folder, its content, and all the subfolders

What I undestand, if I have:

.../configuration-repository/shared-files/
└── dir
    ├── dir2
    │   └── foo.txt
    └── hollymolly.txt

And that I set "dir" in source path, "/tmp" in destination path, is that the content will be:

- Only this file

/tmp/
└── dir/

But it actually does nothing.

- The whole content of the folder

/tmp/
├── dir2 (empty)
└── hollymolly.txt

And it's that!

- The folder, its content, and all the subfolders

/tmp/
└── dir
    ├── dir2
    │   └── foo.txt
    └── hollymolly.txt

But it actually skips "dir" (only content is copied)

Moreover, folder is used a couple of time, when `directory` is used in (many more) other places.

Change into:

- Only this file (or nothing for a directory)
- The direct content of the directory (one level)
- The whole content of the directory (recursively)

(and: Apply the sticky bit to the whole folder? (caution, use with care) => Apply the sticky bit to the whole directory? (caution, use with care)

(even so, that does not seems very consistent. Why the sub-directory is created in second case if skipped in the first? But it can be ok)


Subtasks 1 (0 open1 closed)

Bug #13888: Option description for "dowload for shared files" is mileading and mixed use of folder/directory (rudder 4.3)RejectedFrançois ARMANDActions
Actions #1

Updated by François ARMAND over 2 years ago

  • Description updated (diff)
Actions #2

Updated by François ARMAND over 2 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #3

Updated by François ARMAND over 2 years ago

  • Description updated (diff)
Actions #4

Updated by François ARMAND over 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1374
Actions #5

Updated by François ARMAND over 2 years ago

  • Subject changed from Option descrition for "dowload for shared files" is mileading and mixed use of folder/directory to Option description for "dowload for shared files" is mileading and mixed use of folder/directory
Actions #6

Updated by Rudder Quality Assistant over 2 years ago

  • Assignee changed from Alexis MOUSSET to François ARMAND
Actions #7

Updated by François ARMAND over 2 years ago

  • Status changed from Pending technical review to Pending release
Actions #8

Updated by Vincent MEMBRÉ over 2 years ago

  • Subject changed from Option description for "dowload for shared files" is mileading and mixed use of folder/directory to Option description for "File download (Rudder server)" technique is misleading
Actions #9

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today.
Changelog
Changelog
Changelog
Actions

Also available in: Atom PDF