User story #1469
closed
Popups to create items should be validated when hitting the return key
Description
Popups used to create items ask for a name and a description (sometimes other things too). When you've finished typing, one often hits return to save. However, return currently causes "cancel" to happen instead, which is very counter-intuitive. Hitting return should cause the "save" button to be "clicked".
Exhaustive list:- Group screen, "Create a new item" (for groups and categories)
- Search screen, "Create node group from this query"
- Configuration rule management screen, "Add a new rule"
- Policy Management screen, "Create a new policy based on template X"
- Policy Template library management, "Create a new category"
Updated by François ARMAND over 13 years ago
There is not HTML standard way to specify that:
http://stackoverflow.com/questions/925334/how-is-the-default-submit-button-on-an-html-form-determined
But that workaround seems to work: http://stackoverflow.com/questions/925334/how-is-the-default-submit-button-on-an-html-form-determined/5578124#5578124
So, as it's the simplest, I think we should use it.
Updated by François ARMAND over 13 years ago
Or not, as it does not seems to work with ajax form. So perhaps look at a JQuery solution, like:
Updated by Jonathan CLARKE over 13 years ago
- Target version changed from 16 to 19
Updated by Jonathan CLARKE over 13 years ago
- Target version changed from 19 to 21
Updated by Jonathan CLARKE over 13 years ago
- Target version changed from 21 to 23
Updated by Jonathan CLARKE about 13 years ago
- Target version changed from 23 to 18
Updated by François ARMAND about 13 years ago
- Target version changed from 18 to 2.4.0~alpha1
Updated by François ARMAND about 13 years ago
- Assignee changed from François ARMAND to Arthur ANGLADE
Updated by Arthur ANGLADE about 13 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 0 to 100
Applied in changeset 0c2a0e4eeef1e55db10c92d78803c45e03209da7.
Updated by François ARMAND about 13 years ago
- Status changed from Pending technical review to 2
That seems to not have been sufficiently tested: when on pop-up with other inputs than name/description, the behaviour is still to close the pop-up without saving.
For example, on the search page, when you "create a group from that search", select "dynamic" and press enter, nothing is saved.
Apart from that, the provided correction seems ok.
Updated by François ARMAND about 13 years ago
- Target version changed from 2.4.0~alpha1 to 2.4.0~alpha2
Will have to been corrected for alpha2
Updated by Jonathan CLARKE almost 13 years ago
- Target version changed from 2.4.0~alpha2 to 2.4.0~alpha3
Updated by François ARMAND almost 13 years ago
- Status changed from 2 to Pending technical review
Done in #2078
Updated by Nicolas CHARLES almost 13 years ago
- Status changed from Pending technical review to 10
This looks valid from a technical point of view, thank you Arthur
However, some comments in the js file to explain what the function does and when to use it would have been great
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from 10 to Released
This is not only correct, it's absolutely awesome!!!!! :)