Project

General

Profile

Actions
Copy link

Bug #15334

closed

In 5.1 common policies always return a missing reports on the server

Added by Félix DALLIDET over 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
System techniques
Target version:
6.0.0~beta1
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

The server rudder is always missing a report on the "Update" component when no repaired has been done.
This is most likely due to an error in class guarding translation, in 5.0 we had:

&if(!INITIAL)&
    root_server::
      "${g.rudder_ncf}/common" 
        copy_from         => copy_digest_without_perms("${g.rudder_ncf_origin_common}"),
        depth_search      => recurse_ignore("inf", @{g.excludedreps}),
        perms             => u_mog("644", "root", "0"),
        action            => immediate,
        move_obstructions => "true",
        classes           => success("rudder_ncf_common_updated", "rudder_ncf_common_update_error", "rudder_ncf_common_updated_ok"),
        comment           => "Update the common Rudder ncf instance";
     . . .
&endif&

And if 5.1:

    initial_promises.root_server::
      "${g.rudder_ncf}/common" 
        copy_from         => copy_digest_without_perms("${g.rudder_ncf_origin_common}"),
        perms             => u_mog("644", "root", "0"),
        action            => immediate,
        move_obstructions => "true",
        classes           => success("rudder_ncf_common_updated", "rudder_ncf_common_update_error", "rudder_ncf_common_updated_ok"),
        comment           => "Update the common Rudder ncf instance";

        ...

There is a missing "!" before the guard class

Actions
Copy link

Also available in: Atom PDF