Project

General

Profile

Bug #15800

jinja templating does not clean up the temp files properly

Added by Félix DALLIDET about 2 months ago. Updated 16 days ago.

Status:
Released
Priority:
N/A
Category:
Generic methods - File Management
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

When rendering a template, the .new and .json files are kept. We should remove them after each execution.

It is guarded by a class which is not defined anywhere (state_dumped) which is a bug. Moreover, we are trying to remove the files only when we suppose everything went fine.
We should remove the temp file everytime and remove this logic.

Associated revisions

Revision 1a074986 (diff)
Added by Félix DALLIDET about 2 months ago

Fixes #15800: jinja templating does not clean up the temp files properly

History

#1

Updated by Félix DALLIDET about 2 months ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
#2

Updated by Félix DALLIDET about 2 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/1073
#3

Updated by Félix DALLIDET about 2 months ago

  • Status changed from Pending technical review to Pending release
#6

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.14 which was released today.

Also available in: Atom PDF