Project

General

Profile

Actions

Bug #15800

closed

jinja templating does not clean up the temp files properly

Added by Félix DALLIDET about 5 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

When rendering a template, the .new and .json files are kept. We should remove them after each execution.

It is guarded by a class which is not defined anywhere (state_dumped) which is a bug. Moreover, we are trying to remove the files only when we suppose everything went fine.
We should remove the temp file everytime and remove this logic.

Actions #1

Updated by Félix DALLIDET about 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions #2

Updated by Félix DALLIDET about 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/1073
Actions #3

Updated by Félix DALLIDET about 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:1a0749866340f9777156317d806974bfab42f816.

Actions #4

Updated by Nicolas CHARLES about 5 years ago

  • Fix check changed from To do to Checked
Actions #5

Updated by Alexis Mousset about 5 years ago

  • Name check changed from To do to Reviewed
Actions #6

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.14 which was released today.

Actions #8

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods - File Management to Generic methods
Actions

Also available in: Atom PDF