Project

General

Profile

Actions

Bug #16540

closed

Bug #16382: Improve performance of policy generation writer

We still have one lonely Future which use yet another threadpool

Added by François ARMAND almost 5 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
N/A
Category:
Performance and scalability
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

We have one Future in `ReportsExecutionService`. That triggers the init of `scala` thread pool. We need to get ride of it.

One warning, though: with the future, we weren't correctly handling the accumulation of them, and we should do it to avoid pilling up thread. A one-element queue can do it perfectly.

Actions #1

Updated by François ARMAND almost 5 years ago

  • Status changed from New to In progress
Actions #2

Updated by François ARMAND almost 5 years ago

Actually, it's a bit more complexe, since we want to only invalidate cache for updated node. It can't be a one element queue + discard.

We will have an "offer" logic that will take the current "all" element of the one queue element, and repost the merged set.

Actions #3

Updated by François ARMAND almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2715
Actions #4

Updated by François ARMAND almost 5 years ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by François ARMAND almost 5 years ago

  • Fix check changed from To do to Checked
Actions #6

Updated by Alexis Mousset almost 5 years ago

  • Name check changed from To do to Reviewed
Actions #7

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.0.3 which was released today.

Actions

Also available in: Atom PDF