Project

General

Profile

Actions
Copy link

Bug #16649

closed

Prevent logger string interpolation when logger is not configured in the used level

Added by Nicolas CHARLES almost 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
François ARMAND
Category:
Performance and scalability
Target version:
5.0.17
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

We are sometime doing complex evaluations in logger.trace (or even debug), that can eat up some ressources (big string, sorting collection, etc)
We could simply avoid evaluating these by if (logger.isDebugEnabled) on the previous line

Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 5 years ago

  • Target version set to 5.0.16
Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2748
Actions
Copy link
 #4

Updated by Alexis Mousset almost 5 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from Pending technical review to Rejected
Actions
Copy link

Also available in: Atom PDF