Project

General

Profile

Actions
Copy link

Bug #17036

closed

Change the Makefile command to find all plugin folder

Added by Félix DALLIDET over 4 years ago. Updated over 4 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Packaging
Target version:
6.0
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

It is currently:

find -maxdepth 2 -mindepth 1 -name "build.conf" -printf '%h\n' | cut -c3- | xargs echo

But it does not work with CIS since it has multiple layer of makefile in it with the build.conf being in deeper depth

I think we could run instead:

find . -path ./src -prune -o -name "build.conf" -printf '%P\n' | cut -d "/" -f1 | xargs echo

Which assume ./src will always be excluded, and that all plugin will always have their makefile in the first folder layer, which is currently the case.

Actions
Copy link
 #1

Updated by Félix DALLIDET over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #2

Updated by Félix DALLIDET over 4 years ago

  • Assignee changed from Félix DALLIDET to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/266
Actions
Copy link
 #3

Updated by Félix DALLIDET over 4 years ago

  • Status changed from In progress to Pending release
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF