Actions
Bug #17460
closed
When keyhash is empty, `key-hash` should not be in nodeslist.json node's entry
Pull Request:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
18
Name check:
To do
Fix check:
To do
Regression:
Description
We have case where node are broken (or edge case, when key is deleted, etc) and keyhash is empty.
In that case, we generate:
...
"nodeXX": {
"hostname": "nodeXX.local",
"key-hash": "sha256:",
"policy-server": "root"
}
We should just not write key-hash at all in that case.
Updated by François ARMAND over 4 years ago
- Status changed from New to In progress
Updated by François ARMAND over 4 years ago
- Status changed from In progress to New
- Assignee deleted (
François ARMAND) - Target version changed from 5.0.18 to 6.2.0~beta1
Actually, that json is generated from nodeslist.json.st in string template using system variable SUB_NODES_NAME, SUB_NODES_ID, SUB_NODES_KEYHASH, SUB_NODES_SERVER - which are only used at that point. We can't easily skip that key/value pair.
We should just generate nodeslist.json from webapp and be done - in next minor.
Updated by François ARMAND over 4 years ago
- Severity set to Minor - inconvenience | misleading | easy workaround
- User visibility set to Infrequent - complex configurations | third party integrations
- Priority changed from 0 to 11
Updated by Vincent MEMBRÉ about 4 years ago
- Target version changed from 6.2.0~beta1 to 6.2.0~rc1
- Priority changed from 11 to 20
Updated by François ARMAND about 4 years ago
- Target version changed from 6.2.0~rc1 to 7.0.0~beta1
- Priority changed from 20 to 10
Updated by Alexis Mousset over 3 years ago
- Status changed from New to Rejected
- Priority changed from 10 to 18
key-hash should never be empty anymore, closing.
Actions