Project

General

Profile

Actions

Bug #18856

closed

Event logs are not written when fields are set to empty (ie short description)

Added by Vincent MEMBRÉ almost 4 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

when setting an ldap attribute to empty string it means that we will remove it, hence when we compute a diff from the ldap modification diff we got a null for the empty value instead of an empty string.

That's a quite huge problem in our code since we hope to get string from this function and we now got a null instead of an empty string.

This leads to an exception when we save the diff of the element, since we expect a non null string, and having a null breaks some expectation.

IN 5.0, this means there is no event log produced for change. In 6.2 it means that the change does not appear in the event log (sometimes meaning no changes at all)

We shoud get an empty string instead of a string

This was silenced in most cases, because we don't check when an event log is saved or not, we continue even if it fails. But in sme api we look for this event log, and don't ignore the result of the call.

small example of the behavior in 5.0, we make two modification of the same directive, one adding description, one removing it. We only got thr first event log, adding the description


Files

5.0 - event log.gif (3.83 MB) 5.0 - event log.gif Vincent MEMBRÉ, 2021-01-24 23:59
Actions #1

Updated by Vincent MEMBRÉ almost 4 years ago

add a small example in description of the behavior in 5.0, we make two modification of the same directive, one adding description, one removing it. We only got thr first event log, adding the description

Actions #2

Updated by Vincent MEMBRÉ almost 4 years ago

  • Description updated (diff)
Actions #3

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from New to In progress
Actions #4

Updated by Vincent MEMBRÉ almost 4 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3484
Actions #5

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from In progress to Pending release
Actions #6

Updated by Vincent MEMBRÉ almost 4 years ago

  • Fix check changed from To do to Checked
Actions #7

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 797 to 6.1.10
Actions #8

Updated by Vincent MEMBRÉ over 3 years ago

This bug has been fixed in Rudder 6.1.10 and 6.2.3 which were released by the end of October 2020.

Actions #9

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released
Actions

Also available in: Atom PDF