Bug #1959: Inventories moved to "received" even if the inventory-endpoint cannot contact it's LDAP server - Rudder - Issue Tracker

Actions

Copy link

Bug #1959

closed

Inventories moved to "received" even if the inventory-endpoint cannot contact it's LDAP server

Added by Jonathan CLARKE over 12 years ago. Updated about 9 years ago.

Status:

Released

Priority:

Assignee:

Jonathan CLARKE

Category:

Web - Nodes & inventories

Target version:

2.3.2

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Nicolas just encountered a situation where the inventory-endpoint didn't have a valid LDAP connection. This happens when the LDAP server is not available on startup, as there is no retry or fail mechanism (this is a separate bug). However, what happened here is that the endpoint correctly provided an error message (something like "Can't contact LDAP"), but CFEngine moved the inventory to "received" (from the original "incoming" folder) anyway.

Two possibilities arise here:

CFEngine doesn't properly check the HTTP return code, and moves the inventories even if there was an error sending them to the endpoint
The endpoint doesn't properly return an error code in this case

This is quite a bother, since it's very hard to detect this situation when using Rudder.

I will start by checking 1 above.

Actions

Copy link

Updated by Jonathan CLARKE over 12 years ago

Jonathan CLARKE wrote:

Two possibilities arise here:

CFEngine doesn't properly check the HTTP return code, and moves the inventories even if there was an error sending them to the endpoint

The endpoint doesn't properly return an error code in this case

I will start by checking 1 above.

This is indeed the case, curl is missing the "-f" option to detect this. Commiting a fix now.

Actions

Copy link