Project

General

Profile

Actions

User story #20130

closed

rudder language generate_lib should use the existing ncf python library instead of implement itself the ncf methods parsing

Added by Félix DALLIDET about 3 years ago. Updated about 3 years ago.

Status:
Released
Priority:
N/A
Category:
rudderc
Target version:
UX impact:
Suggestion strength:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Name check:
To do
Fix check:
To do
Regression:

Description

We already have a parser written in python for the methods in ncf, we should use it whenever possible and not maintain several code bases.
The ticket also fix several parsing issues, all the changes will be listed below:
  • all methods now have a @documentation even if empty
  • fix missing method renaming
  • variable resource parameters are now always "prefix" and "name" instead of "prefix|variable_prefix" and "name"
  • dsc_built_in_resource now has its parameters in the correct order
  • the Json object used to generate the stdlib can have its resource parameters description modified based on method parsing order (but I did not find anything using it except the doc)
  • the generate_lib script now outputs the resulting Json in its stdout, this make debugging much easier but we need to supress output when calling it from other scripts (and for instance only keep the .data.errors)

Subtasks 1 (0 open1 closed)

User story #20162: The dsc based methods are not properly parsedReleasedBenoît PECCATTEActions
Actions #1

Updated by Félix DALLIDET about 3 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions #2

Updated by Félix DALLIDET about 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder/pull/3938
Actions #3

Updated by Félix DALLIDET about 3 years ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Vincent MEMBRÉ about 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.0.0~beta2 which was released today.

Actions

Also available in: Atom PDF