Project

General

Profile

Actions
Copy link

Bug #2036

closed

Do not use .attr() jquery method to get/set properties

Added by François ARMAND over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
3
Assignee:
Arthur ANGLADE
Category:
Web - UI & UX
Target version:
2.4.0~alpha4
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Since jQuery 1.6, .attr() and .prop() methods have clear, different specifications.

We should use .prop() each time we want to change or read the current value of an attribute, not its initial value.

See: http://api.jquery.com/prop/

Actions
Copy link
 #1

Updated by François ARMAND over 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by Nicolas CHARLES over 12 years ago

  • Status changed from Pending technical review to In progress

I'm sorry, but the correction is incomplete.
The rudder.js file contains many $('something).attr("foo", bar);

Actions
Copy link
 #3

Updated by François ARMAND over 12 years ago

  • Assignee deleted (François ARMAND)
  • Target version changed from 2.3.3 to 2.4.0~alpha3
Actions
Copy link
 #4

Updated by François ARMAND about 12 years ago

  • Target version changed from 2.4.0~alpha3 to 2.4.0~alpha4
Actions
Copy link
 #5

Updated by François ARMAND about 12 years ago

  • Assignee set to Arthur ANGLADE
Actions
Copy link
 #6

Updated by Arthur ANGLADE about 12 years ago

  • Status changed from In progress to Pending technical review
Actions
Copy link
 #7

Updated by François ARMAND about 12 years ago

  • Status changed from Pending technical review to Released

Seems OK.

Actions
Copy link
 #8

Updated by François ARMAND about 12 years ago

In fact, we discoverd some more evolution on that, see #2239

Actions
Copy link

Also available in: Atom PDF