Bug #20943
closed
Rudder incorectly parse URL with a '+' in the path into spaces
Description
It always transform it to a space character, but it should not do it for the PATH part, see https://stackoverflow.com/a/29948396 for an explanation.
I think it's only of importance for API that uses the path for resources, since we don't analyse path content by oursefves in other cases, only parameters (and these are OK AFAIK).
The correct correction would be to change lift decoding, but lift is ~ no more supported, and the sides effects may be extremelly far reaching (perhaps a ton of code in lift relies on that bug).
So I propose to only correct the problem in our API Path parsing, and at no other places.
Updated by François ARMAND over 2 years ago
- Status changed from New to In progress
- Assignee set to François ARMAND
Updated by François ARMAND over 2 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/4217
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.2.13 to 6.2.14
Updated by François ARMAND over 2 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|0c794c1b72c81b09c91d0615bd571389915aea67.
Updated by François ARMAND over 2 years ago
It's OK but the parsing of id is not correct, making that change a bit useless
Updated by François ARMAND over 2 years ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ over 2 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 6.2.14 which was released today.