Actions
Architecture #2115
closedFactor out success pop-up
Pull Request:
Effort required:
Name check:
Fix check:
Regression:
Description
In a lot of place, both in HTML and in JS, we have the same code for the "success pop-up".
All that code should be defined in only one place!
- the "success" pop-up HTML should be in the common-layout template, always available;
- the js fonction displaying it should be in our js file.
Updated by Arthur ANGLADE about 13 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 0 to 100
Applied in changeset 7ede42321d46c6b0bc140f07b7db14c0eb62844a.
Updated by Nicolas CHARLES almost 13 years ago
- Status changed from Pending technical review to 10
This seems valid, thank you Arthur
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from 10 to Released
Closing these "Architecture" issues without a functional review - this step of the workflow has no sense here, there is no functional impact on code architecture changes (or there shouldn't be anyway!).
I think we should remove this step from the workflow for Architecture issues.
Actions