Actions
Architecture #2133
closed
some pics deleted were used. the new path to pics need to be added in pics path
Pull Request:
Effort required:
Name check:
Fix check:
Regression:
Updated by Arthur ANGLADE about 13 years ago
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
Applied in changeset c414b5e054e833e213990f1f82223d112fa7e6e8.
Updated by Jonathan CLARKE about 13 years ago
- Target version set to 2.4.0~alpha2
Arthur - please make sure to always set a target version for any issues you fix. Thanks!
Updated by Arthur ANGLADE about 13 years ago
Applied in changeset 8d954f5cc256c14b7a58ca8f842e9b18535a5bd2.
Updated by François ARMAND almost 13 years ago
- Status changed from Pending technical review to Discussion
- Target version changed from 2.4.0~alpha2 to 2.4.0~alpha5
That diff seems higly suspicious: http://www.rudder-project.org/redmine/projects/rudder/repository/revisions/c414b5e054e833e213990f1f82223d112fa7e6e8/diff
There is a lot of path looking like "images/ui-bg_..." transform to "/images/themes/ui-lightness/imagesui-bg_..."
=> isn't there a missing "/" after the seconde image ?
Moreover, why CSS in the directory "udder-web/src/main/webapp/images/themes/base/" are modified ? That is a "base" theme, so it should not be modified by us.
Updated by François ARMAND almost 13 years ago
- Status changed from Discussion to Pending technical review
- Assignee changed from Arthur ANGLADE to Jonathan CLARKE
The correction seems to have be already done.
Updated by François ARMAND almost 13 years ago
- Status changed from Pending technical review to Released
- Priority changed from N/A to 4
OK.
Updated by François ARMAND almost 13 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
Actions