Architecture #2133: some pics deleted were used. the new path to pics need to be added in pics path - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Architecture #2133

closed

some pics deleted were used. the new path to pics need to be added in pics path

Added by Arthur ANGLADE almost 13 years ago. Updated almost 13 years ago.

Status:

Released

Priority:

Assignee:

François ARMAND

Category:

Web - UI & UX

Target version:

2.4.0~alpha5

Pull Request:

Effort required:

Name check:

Fix check:

Regression:

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Arthur ANGLADE almost 13 years ago

Status changed from New to Pending technical review
% Done changed from 0 to 100

Applied in changeset c414b5e054e833e213990f1f82223d112fa7e6e8.

Actions

Copy link

Updated by Jonathan CLARKE almost 13 years ago

Target version set to 2.4.0~alpha2

Arthur - please make sure to always set a target version for any issues you fix. Thanks!

Actions

Copy link

Updated by Arthur ANGLADE almost 13 years ago

Applied in changeset 8d954f5cc256c14b7a58ca8f842e9b18535a5bd2.

Actions

Copy link

Updated by François ARMAND almost 13 years ago

Status changed from Pending technical review to Discussion
Target version changed from 2.4.0~alpha2 to 2.4.0~alpha5

That diff seems higly suspicious: http://www.rudder-project.org/redmine/projects/rudder/repository/revisions/c414b5e054e833e213990f1f82223d112fa7e6e8/diff

There is a lot of path looking like "images/ui-bg_..." transform to "/images/themes/ui-lightness/imagesui-bg_..."
=> isn't there a missing "/" after the seconde image ?

Moreover, why CSS in the directory "udder-web/src/main/webapp/images/themes/base/" are modified ? That is a "base" theme, so it should not be modified by us.

Actions

Copy link