Project

General

Profile

Actions
Copy link

Bug #2142

closed

/etc/init.d/rudder-server-root exists on Debian, not on SLES

Added by Nicolas PERRON over 12 years ago. Updated about 9 years ago.

Status:
Released
Priority:
2
Assignee:
Nicolas PERRON
Category:
Packaging
Target version:
2.3.7
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Actions
Copy link
 #1

Updated by Jonathan CLARKE about 12 years ago

  • Target version changed from 2.3.6 to 2.3.7
Actions
Copy link
 #2

Updated by Nicolas PERRON about 12 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:63edf9a8ccfe53d64711a618c8fa7ee46c5c3b1f.

Actions
Copy link
 #3

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to In progress
  • % Done changed from 100 to 90

This looks good, aside from one detail: when you create files in the Makefile, please remember to clean them up too! You should add a rm -f command to the localclean: target for the init script you copy into debian/.

Actions
Copy link
 #4

Updated by Jonathan CLARKE about 12 years ago

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

Actions
Copy link
 #5

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 90 to 100

Applied in changeset commit:b10178f0d51df945936e766f84d7100375dd1ad1.

Actions
Copy link
 #6

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to 2

Whoops, this was merged but still needs fixing!

Actions
Copy link
 #7

Updated by Nicolas PERRON about 12 years ago

  • Status changed from 2 to Pending technical review
Actions
Copy link
 #8

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to 2
  • % Done changed from 100 to 90

Jonathan CLARKE wrote:

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

Please address this comment.

Actions
Copy link
 #9

Updated by Nicolas PERRON about 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 90 to 100

Jonathan CLARKE wrote:

Jonathan CLARKE wrote:

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

Please address this comment.

This is repaired

Actions
Copy link
 #10

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to Released

Thanks, looks good now

Actions
Copy link
 #11

Updated by Nicolas PERRON about 11 years ago

  • Project changed from Rudder to 34
  • Category deleted (11)
Actions
Copy link
 #12

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions
Copy link

Also available in: Atom PDF