Bug #2142
closed
/etc/init.d/rudder-server-root exists on Debian, not on SLES
Added by Nicolas PERRON almost 13 years ago. Updated over 9 years ago.
Updated by Jonathan CLARKE almost 13 years ago
- Target version changed from 2.3.6 to 2.3.7
Updated by Nicolas PERRON almost 13 years ago
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
Applied in changeset commit:63edf9a8ccfe53d64711a618c8fa7ee46c5c3b1f.
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from Pending technical review to In progress
- % Done changed from 100 to 90
This looks good, aside from one detail: when you create files in the Makefile, please remember to clean them up too! You should add a rm -f command to the localclean: target for the init script you copy into debian/.
Updated by Jonathan CLARKE almost 13 years ago
While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 90 to 100
Applied in changeset commit:b10178f0d51df945936e766f84d7100375dd1ad1.
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from Pending technical review to 2
Whoops, this was merged but still needs fixing!
Updated by Nicolas PERRON almost 13 years ago
- Status changed from 2 to Pending technical review
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from Pending technical review to 2
- % Done changed from 100 to 90
Jonathan CLARKE wrote:
While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.
Please address this comment.
Updated by Nicolas PERRON almost 13 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 90 to 100
Jonathan CLARKE wrote:
Jonathan CLARKE wrote:
While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.
Please address this comment.
This is repaired
Updated by Jonathan CLARKE almost 13 years ago
- Status changed from Pending technical review to Released
Thanks, looks good now
Updated by Nicolas PERRON almost 12 years ago
- Project changed from Rudder to 34
- Category deleted (
11)
Updated by Benoît PECCATTE over 9 years ago
- Project changed from 34 to Rudder
- Category set to Packaging